[Access] 4506 - Make CCF encoded events optional via request parameter #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guitarheroua
requested review from
sideninja,
turbolent,
janezpodhostnik and
bluesign
as code owners
turbolent
requested review from
a team,
koko1123 and
peterargue
and removed request for
a team
|
@Guitarheroua can you pull in master and resolve these conflicts? |
turbolent
approved these changes
Oct 24, 2023
tarakby
reviewed
Nov 8, 2023
| @@ -190,3 +190,6 @@ require ( | |||
| modernc.org/sqlite v1.21.1 // indirect | |||
| nhooyr.io/websocket v1.8.7 // indirect | |||
| ) | |||
|
|
|||
| //TODO: Remove when both version will be merged | |||
| replace github.com/onflow/flow-go v0.32.3 => github.com/Guitarheroua/flow-go v0.0.0-20231024184136-247768e776f7 | |||
There was a problem hiding this comment.
@peterargue do you know if we can remove this statement? does flow-go has the required changes?
There was a problem hiding this comment.
yes, though we haven't tagged a release including this yet. should be tagged later this afternoon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onflow/flow-go#4506
Context
This pull request introduces a new request parameter for a list of endpoints from the AccessAPI and the ExecutionDataAPI, which specifies the encoding for events.
As part of this PR: