Bump cadence and flow-go dependencies
#483
Conversation
m-Peter
requested review from
sideninja,
turbolent,
janezpodhostnik and
bluesign
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 54.85% 54.81% -0.05%
==========================================
Files 28 28
Lines 3624 3645 +21
==========================================
+ Hits 1988 1998 +10
- Misses 1476 1487 +11
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
m-Peter
force-pushed
the
bump-cadence-dependency
branch
from
9fb3ba2 to
dbef27c
Compare
| &state_stream.StateStreamBackend{}, | ||
| state_stream.DefaultEventFilterConfig, | ||
| state_stream.DefaultMaxGlobalStreams, |
There was a problem hiding this comment.
@onflow/flow-access Does this look good?
storage/remote/store.go
Outdated
| ledgerKeys, _ := exeState.RegisterEntriesToKeysValues( | ||
| flowgo.RegisterEntries{ | ||
| { | ||
| Key: flowgo.RegisterID{Key: id.Key, Owner: id.Owner}, | ||
| Value: value, | ||
| }, | ||
| }) | ||
| ledgerPath, err := pathfinder.KeyToPath( | ||
| ledgerKeys[0], | ||
| complete.DefaultPathFinderVersion, | ||
| ) |
There was a problem hiding this comment.
@onflow/flow-execution-and-verification Does this look good?
| debugLogger, | ||
| chain, | ||
| restCollector, | ||
| &state_stream.StateStreamBackend{}, |
There was a problem hiding this comment.
maybe nil here? Probably we don't have streaming in emulator.
There was a problem hiding this comment.
You're right, we don't have it yet. I just added it to make it easier for the fellow dev that will add it 😅
turbolent
added
the
Improvement
|
Thanks @turbolent, I have added relevant commits regarding the breaking API changes, to provide a reference for the protocol team 🙏 |
| @@ -194,8 +194,17 @@ func (s *Store) LedgerByHeight( | |||
| return value, nil | |||
| } | |||
|
|
|||
| ledgerKey := exeState.RegisterIDToKey(flowgo.RegisterID{Key: id.Key, Owner: id.Owner}) | |||
| ledgerPath, err := pathfinder.KeyToPath(ledgerKey, complete.DefaultPathFinderVersion) | |||
| ledgerKeys, _ := exeState.RegisterEntriesToKeysValues( | |||
There was a problem hiding this comment.
maybe RegisterIDToLedgerKey ?
|
I've released
|
m-Peter
force-pushed
the
bump-cadence-dependency
branch
from
dbef27c to
013362a
Compare
|
Thanks Supun 🙌 💯 |
Description
cadencetov0.42.0release andflow-goto latest master commit, which updatescadencetov0.42.0.For contributor use:
masterbranchFiles changedin the GitHub PR explorer