Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import aliasing #3717

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Import aliasing #3717

wants to merge 8 commits into from

Conversation

RZhang05
Copy link
Contributor

@RZhang05 RZhang05 commented Dec 16, 2024 •
edited
Loading

Closes #1171

Description

Introduces import aliases.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@RZhang05 RZhang05 self-assigned this Dec 16, 2024
@RZhang05 RZhang05 marked this pull request as ready for review December 17, 2024 18:53
@turbolent turbolent requested a review from jsproz December 17, 2024 19:20
turbolent
turbolent reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Just a few minor suggestions, but overall looks great! Good to see the main change is simple 👌

ast/import_test.go Outdated Show resolved Hide resolved
interpreter/import_test.go Show resolved Hide resolved
interpreter/interpreter_import.go Outdated Show resolved Hide resolved
parser/declaration.go Outdated Show resolved Hide resolved
sema/check_import_declaration.go Outdated Show resolved Hide resolved
sema/check_import_declaration.go Outdated Show resolved Hide resolved
sema/import_test.go Show resolved Hide resolved
turbolent
turbolent approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@RZhang05 RZhang05

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support referencing duplicate contracts (deployed to different accounts) in cadence context
2 participants
@RZhang05 @turbolent