-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup review feedback on e2e codegen example #876
Followup review feedback on e2e codegen example #876
Conversation
It would make since that this is related to gpus page size, but not sure how to make sure of that. I think it will need to be generalized if it will run on anything other than L0. |
I would think that would still be blocked by this issue, so it will be hard to test that while failure, I think that could be added as a seperate PR with a seperate issue when the L0 pipeline is fixed. |
45f3701
to
905699f
Compare
I guess 4k is a safe enough value... I'd still do a define/const variable instead of having a magic number though. |
The L0 workflow is not blocked, that test is simply not ran in CI (plus there's a timeout). But I agree that it might make sense to do this in another PR. |
b418b8d
to
05d7bb9
Compare
I created this issue to track this. I was trying to attach it to this pr but it seems that it will not work directly and might be controversial in some parts. so, will submit it to a new pr. |
05d7bb9
to
398e8b1
Compare
398e8b1
to
bceddab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bceddab
to
d2edad6
Compare
This PR is a follow up PR to address the rest of review feedback on 610. It contains:
Fixes: 859