Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cooperative kernels experimental feature #849

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Add cooperative kernels experimental feature #849

merged 1 commit into from
Sep 15, 2023

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Sep 5, 2023

Add two new functions for working with cooperative kernels:

  • urKernelSuggestMaxCooperativeGroupCount
  • urEnqueueCooperativeKernelLaunch

@0x12CC
Copy link
Contributor Author

0x12CC commented Sep 5, 2023

This feature is needed to support the implementation of root groups in SYCL: intel/llvm#11043. This PR needs the experimental label but I'm not able to add it.

@kbenzie kbenzie added the experimental Experimental feature additions/changes/specification label Sep 11, 2023
@0x12CC
Copy link
Contributor Author

0x12CC commented Sep 11, 2023

@kbenzie, could you please review this PR?

kbenzie
kbenzie reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just need to add the Exp suffix to the experimental function names and run the generate target again.

scripts/core/EXP-COOPERATIVE-KERNELS.rst Outdated Show resolved Hide resolved
scripts/core/EXP-COOPERATIVE-KERNELS.rst Outdated Show resolved Hide resolved
scripts/core/exp-cooperative-kernels.yml Outdated Show resolved Hide resolved
scripts/core/exp-cooperative-kernels.yml Outdated Show resolved Hide resolved
@0x12CC
Copy link
Contributor Author

0x12CC commented Sep 12, 2023

Thanks! I've made the requested changes.

@0x12CC 0x12CC requested a review from kbenzie September 12, 2023 16:27
@kbenzie kbenzie merged commit 12c8312 into oneapi-src:main Sep 15, 2023
26 checks passed
@0x12CC 0x12CC deleted the cooperative_kernels branch September 15, 2023 13:43
@0x12CC 0x12CC mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycm alycm alycm left review comments

@callumfare callumfare callumfare approved these changes

@veselypeta veselypeta veselypeta approved these changes

@kbenzie kbenzie kbenzie approved these changes

Assignees
No one assigned
Labels
experimental Experimental feature additions/changes/specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0x12CC @kbenzie @alycm @veselypeta @callumfare