Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command_buffer coverity issues #2379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix command_buffer coverity issues #2379

wants to merge 1 commit into from

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Nov 25, 2024

  • Change command handle constructors to accept const ref for vector types
  • Add std::move to certain vector assignments
  • Add missing call to store command handle in command buffer in urCommandBufferAppendMemBufferCopyExp

@Bensuo
Fix command_buffer coverity issues
8cc20ff 
- Change command handle constructors to accept const ref for vector types
- Add std::move to certain vector assignments
- Add missing call to store command handle in command buffer in urCommandBufferAppendMemBufferCopyExp
@Bensuo Bensuo requested a review from a team as a code owner November 25, 2024 17:34
@github-actions github-actions bot added cuda CUDA adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 25, 2024
@EwanC EwanC added the v0.11.x Include in the v0.11.x release label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification cuda CUDA adapter specific issues v0.11.x Include in the v0.11.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bensuo @EwanC