Improve logging of loading adapters on Windows #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily improves the logging when loading an adapter fails on Windows by printing out the result of `GetLastError()` when `LoadLibrarExA()` returns null for cross-reference with https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes.
kbenzie
force-pushed
the
benie/windows-improve-adapter-load-logging
branch
from
bf8d48b
to
da5befe
Compare
aarongreig
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily improves the logging when loading an adapter fails on Windows by printing out the result of
GetLastError()whenLoadLibrarExA()returns null for cross-reference with https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes.