Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change urSuggestMaxCooperativeGroupCountExp to accept ND size parameter #2316

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Nov 12, 2024

The L0 API requires calling zeKernelSetGroupSize before zeKernelSuggestMaxCooperativeGroupCount to ensure that the query result is correct. This PR changes urSuggestMaxCooperativeGroupCountExp to accept a group size with uint32_t *pworkDim and const size_t **ppLocalWorkSize parameters.

@0x12CC 0x12CC requested review from a team as code owners November 12, 2024 15:37
@github-actions github-actions bot added loader Loader related feature/bug specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues labels Nov 12, 2024
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP changes LGTM!

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Level Zero LGTM.

@github-actions github-actions bot added the opencl OpenCL adapter specific issues label Nov 25, 2024
@0x12CC
Copy link
Contributor Author

0x12CC commented Nov 26, 2024

@nrspruit, do you know why the checks for this PR are failing? The logs show the following CMake error:

Initialized empty Git repository in /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/content-xptifw/.git/
Switched to a new branch 'main'
error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
error: 6400 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
error: pathspec 'nightly-2024-10-22' did not match any file(s) known to git
CMake Error at /usr/share/cmake-3.22/Modules/ExternalProject.cmake:2882 (message):
  No download info given for 'xptifw-populate' and its source directory:

   /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/content-xptifw/xptifw

  is not an existing non-empty directory.  Please specify one of:

   * SOURCE_DIR with an existing non-empty directory
   * DOWNLOAD_COMMAND
-- Configuring incomplete, errors occurred!
   * URL
   * GIT_REPOSITORY
   * SVN_REPOSITORY
   * HG_REPOSITORY
   * CVS_REPOSITORY and CVS_MODULE
Call Stack (most recent call first):
See also "/home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/CMakeFiles/CMakeOutput.log".
See also "/home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/CMakeFiles/CMakeError.log".
  /usr/share/cmake-3.22/Modules/ExternalProject.cmake:3[71](https://github.com/oneapi-src/unified-runtime/actions/runs/12015205795/job/33492789820?pr=2316#step:5:72)6 (_ep_add_download_command)
  CMakeLists.txt:15 (ExternalProject_Add)


-- Configuring incomplete, errors occurred!

I don't believe this error is caused by my changes but I'm also not sure if it's failing in any other PR.

@0x12CC
Copy link
Contributor Author

0x12CC commented Nov 27, 2024

All SYCL tests for this PR are passing in intel/llvm#16051.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug opencl OpenCL adapter specific issues specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants