-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change urSuggestMaxCooperativeGroupCountExp
to accept ND size parameter
#2316
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA and HIP changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Level Zero LGTM.
@nrspruit, do you know why the checks for this PR are failing? The logs show the following CMake error:
I don't believe this error is caused by my changes but I'm also not sure if it's failing in any other PR. |
All SYCL tests for this PR are passing in intel/llvm#16051. |
The L0 API requires calling
zeKernelSetGroupSize
beforezeKernelSuggestMaxCooperativeGroupCount
to ensure that the query result is correct. This PR changesurSuggestMaxCooperativeGroupCountExp
to accept a group size withuint32_t *pworkDim
andconst size_t **ppLocalWorkSize
parameters.