[UR] Initial spec for the enqueue allocation API #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
force-pushed
the
async-spec
branch
from
af9b768
to
d0c58ef
Compare
github-actions
bot
added
loader
kswiecicki
force-pushed
the
async-spec
branch
from
d0c58ef
to
697d6f7
Compare
kswiecicki
force-pushed
the
async-spec
branch
2 times, most recently
from
2ba7bc6
to
bc9d8a4
Compare
First basic work in progress spec.
kswiecicki
force-pushed
the
async-spec
branch
from
bc9d8a4
to
c854119
Compare
|
@oneapi-src/unified-runtime-native-cpu-write, @oneapi-src/unified-runtime-opencl-write, @oneapi-src/unified-runtime-hip-write, @oneapi-src/unified-runtime-cuda-write, @oneapi-src/unified-runtime-level-zero-write. |
pbalcer
approved these changes
Nov 25, 2024
aarongreig
approved these changes
Nov 25, 2024
| UR command enqueues without forcing synchronization points in the asynchronous | ||
| command DAG associated with a queue. This can allow applications to compose | ||
| memory allocation and command execution asynchronously, which can improve | ||
| performancet. |
There was a problem hiding this comment.
Suggested change
| performancet. | |
| performance. |
| name: hQueue | ||
| desc: "[in] handle of the queue object" | ||
| - type: $x_usm_pool_handle_t | ||
| desc: "[in][optional] handle of the USM memory pooliptor" |
There was a problem hiding this comment.
Suggested change
| desc: "[in][optional] handle of the USM memory pooliptor" | |
| desc: "[in][optional] handle of the USM memory pool" |
igchor
reviewed
Nov 25, 2024
| - type: $x_queue_handle_t | ||
| name: hQueue | ||
| desc: "[in] handle of the queue object" | ||
| - type: $x_usm_pool_handle_t |
There was a problem hiding this comment.
Just to make sure, are we using the same pool handle as for regular allocations, instead of introducing a new pool type? I don't remember what was decided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those changes are based on the initial PR (#2180) with minor changes, wording and CI testing fixes.