-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeviceAsan] Serval bug fixes #2293
base: main
Are you sure you want to change the base?
[DeviceAsan] Serval bug fixes #2293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Convert to draft to try to add another fix. |
Hi @zhaomaosu , please review the latest change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @pbalcer , would you please help review this PR? It has been updated since your last review. Thank you! |
CI failures seem not related to the PR change. Are they known failures? Or can we restart the CI? |
I pushed a fix commit an hour ago, but yet it does not appear on the PR page. I don't know if that would cause problems. I think Github is having some issues here. Therefore please wait for @zhaomaosu 's approval. |
Yeah, I've been seeing issues with GitHub as well. |
After team discussion, we decide not to insertProgram when build failure, and just ingore the un-inserted program in the urProgramRelease. |
5a10a41
to
093a95d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
SanitizerInterceptor::releaseMemory()
, leading to double release of theAllocInfo
and not release the out-of-quarantine allocations.insertProgram()
beforeregisterProgram()
if the API creates new program(in this case, urProgramLink[Exp]), or we cannot find this program and will trigger assertion.insertProgram()
will not be called, leading to cannot find program in time ofreleaseProgram()
. We should ignore them inreleaseProgram()
in such case.