Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit tests for cuda_add_cufft_to_target #1508

Conversation

TejaX-Alaghari
Copy link
Contributor

@TejaX-Alaghari TejaX-Alaghari commented Dec 11, 2023

Added lit test for cuda_add_cufft_to_target CMake macro

@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch 10 times, most recently from 8cb6182 to 0d41070 Compare December 19, 2023 19:20
@TejaX-Alaghari TejaX-Alaghari changed the title Lit tests for target_compile_features and cuda_add_cufft_to_target Lit tests for find_package and cuda_add_cufft_to_target Dec 19, 2023
@TejaX-Alaghari TejaX-Alaghari changed the title Lit tests for find_package and cuda_add_cufft_to_target Lit tests for cuda_add_cufft_to_target Dec 21, 2023
@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch 2 times, most recently from b3827d2 to 5f579db Compare December 27, 2023 06:54
@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch 3 times, most recently from 2bebcec to 55ee40c Compare January 3, 2024 02:57
@TejaX-Alaghari
Copy link
Contributor Author

Raised the behaviour test PR#573 for dpct_add_mkl_to_target

@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch from 55ee40c to a72ee1b Compare January 3, 2024 07:25
@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch from a72ee1b to 295aa21 Compare January 4, 2024 04:02
@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch from 295aa21 to 55e6b78 Compare January 4, 2024 17:40
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch 3 times, most recently from 059caf8 to 1f6a98c Compare January 8, 2024 08:14
Copy link
Contributor

@zhiweij1 zhiweij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you prepare a full CUDA test case in https://github.com/intel-sandbox/cmake_script_migration ?

@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch from 1f6a98c to 56f54b1 Compare January 9, 2024 05:04
@TejaX-Alaghari TejaX-Alaghari force-pushed the cmake_script_migration_lit_part2 branch from 56f54b1 to 2894f17 Compare January 9, 2024 11:36
@zhimingwang36
Copy link
Contributor

Need rebase to solve the conflicting files

@zhimingwang36 zhimingwang36 merged commit 86472bf into oneapi-src:SYCLomatic Jan 10, 2024
0 of 6 checks passed
@TejaX-Alaghari TejaX-Alaghari deleted the cmake_script_migration_lit_part2 branch January 10, 2024 08:26
zhimingwang36 pushed a commit that referenced this pull request Jul 23, 2024
Some of the upstream PRs are getting backported to the llvm_release_* branches, but those changes are never released. That prevents them from distributing as precompiled packages in various distributions like conda-forge and others. This PR targets this issue by creating automated workflow that is triggered once a month and generates automated releases for each such branch if there were changes since last release.

This PR
Adds workflow to generate releases every month from llvm_release_* branches in the format %llvm_major%.%llvm_minor%.%latest patch version +1%. For example:
v18.1.1
v17.0.2
v17.0.1
v14.0.1
etc

Release description matches as close as possible to current releases. The only difference is that llvm versions is represented by two numbers, instead of three, because it is impossible to recover exact version. You can check out example of generated versions here (there are few releases from the original proposal): https://github.com/ZzEeKkAa/SPIRV-LLVM-Translator/releases
Workflow is set to be triggered once a month. It is also possible to trigger it manually from github actions UI.

Merge process
Merge the PR to main
Trigger workflow manually

Note
There is no need to backport changes to all branches, since workflow dispatch on schedule basis can be performed only from main branch.

Fixes: #1898
Fixes: #1508

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@63e89a9a268e5c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants