Fix NameResolver for class constant native type

ondrejmirtes · Nov 28, 2023 · c0b1f07 · c0b1f07
1 parent d0b3512
commit c0b1f07
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/lib/PhpParser/NodeVisitor/NameResolver.php b/lib/PhpParser/NodeVisitor/NameResolver.php
@@ -115,6 +115,9 @@ public function enterNode(Node $node) {
                 $this->addNamespacedName($const);
             }
         } elseif ($node instanceof Stmt\ClassConst) {
+            if (null !== $node->type) {
+                $node->type = $this->resolveType($node->type);
+            }
             $this->resolveAttrGroups($node);
         } elseif ($node instanceof Stmt\EnumCase) {
             $this->resolveAttrGroups($node);

diff --git a/test/PhpParser/NodeVisitor/NameResolverTest.php b/test/PhpParser/NodeVisitor/NameResolverTest.php
@@ -188,7 +188,7 @@ class A extends B implements C, D {
         E::h as i;
         E::j insteadof F, G;
     }
-    
+
     #[X]
     public float $php = 7.4;
     public ?Foo $person;
@@ -535,6 +535,27 @@ public function testAttributeOnlyMode() {
             new Name\FullyQualified('Foo\bar'), $n2->getAttribute('namespacedName'));
     }
 
+
+    public function testClassConstantNativeType() {
+        $source = <<<'EOC'
+<?php
+namespace Foo;
+class Bar
+{
+    public const X A = X::Bar;
+    public const X\Foo B = X\Foo::Bar;
+    public const \X\Foo C = \X\Foo::Bar;
+}
+EOC;
+
+        $stmts = $this->parseAndResolve($source);
+        $classStmt = $stmts[0]->stmts[0];
+
+        $this->assertSame('Foo\\X', (string) $classStmt->stmts[0]->type);
+        $this->assertSame('Foo\\X\\Foo', (string) $classStmt->stmts[1]->type);
+        $this->assertSame('X\\Foo', (string) $classStmt->stmts[2]->type);
+    }
+
     private function parseAndResolve(string $code): array {
         $parser = new PhpParser\Parser\Php7(new PhpParser\Lexer\Emulative());
         $traverser = new PhpParser\NodeTraverser();