Problem: hard-coded transaction gas #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it very to make a mistake when configuring the bridge and have failing transactions as a result. Solution: use `eth.estimateGas` call for every transaction Configuration values for `gas` will be only used if they are set and non-zero. If `estimateGas` fails, the transaction will be thrown out as it will be assumed that it is failing and therefore we shouldn't waste resources on it.
ghost
assigned 
DrPeterVanNostrand
approved these changes
Jun 14, 2018
|
What would be important to do before merging this is to research rpc error codes that indicate that we should NOT throw out the transaction. Otherwise we have a chance of throwing out transactions that are legitimate but something went wrong at the node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it very to make a mistake when configuring
the bridge and have failing transactions as a result.
Solution: use
eth.estimateGascall for every transactionConfiguration values for
gaswill be only used if theyare set and non-zero.
If
estimateGasfails, the transaction will be thrown outas it will be assumed that it is failing and therefore we
shouldn't waste resources on it.