This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
prevent overflow in RootChain.sol deposit #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boolafish
approved these changes
Jan 30, 2019
|
Sorry for late response. However, I don't know do I have time or resource to fix this repo now or not, I am guessing some dependency updated and the tests starts to fail. Once I got time to fix this I will merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploit scenario:
user calls
deposit()withamountset as115792089237316195423570985008687907853269984665640564039458but only sends415992086870360064wei.An alternative solution would be to use the SafeMath library.
I don't have time to do it at the moment, but unit tests for the contracts should be added as well