Thorough dialyzer analysis (#424)

omgnetwork · Aug 17, 2018 · a0a6a76 · a0a6a76
1 parent b8f3860
commit a0a6a76
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/apps/ewallet/lib/ewallet/fetchers/transaction_consumption_fetcher.ex b/apps/ewallet/lib/ewallet/fetchers/transaction_consumption_fetcher.ex
@@ -22,7 +22,7 @@ defmodule EWallet.TransactionConsumptionFetcher do
   defp return_consumption(consumption), do: {:ok, consumption}
 
   @spec idempotent_fetch(String.t()) ::
-          {:ok, %TransactionConsumption{}}
+          {:ok, nil}
           | {:idempotent_call, %TransactionConsumption{}}
           | {:error, %TransactionConsumption{}, atom(), String.t()}
           | {:error, %TransactionConsumption{}, String.t(), String.t()}

diff --git a/apps/ewallet/lib/ewallet/gates/transaction_consumption_confirmer_gate.ex b/apps/ewallet/lib/ewallet/gates/transaction_consumption_confirmer_gate.ex
@@ -17,8 +17,7 @@ defmodule EWallet.TransactionConsumptionConfirmerGate do
   alias Ecto.Changeset
 
   @spec approve_and_confirm(%TransactionRequest{}, %TransactionConsumption{}) ::
-          {:ok, %TransactionConsumption{}}
-          | {:error, %TransactionConsumption{}, atom(), String.t()}
+          {:error, %TransactionConsumption{}, atom(), String.t()}
           | {:error, %TransactionConsumption{}, String.t(), String.t()}
   def approve_and_confirm(request, consumption) do
     consumption

diff --git a/apps/ewallet/lib/ewallet/gates/transaction_consumption_consumer_gate.ex b/apps/ewallet/lib/ewallet/gates/transaction_consumption_consumer_gate.ex
@@ -31,6 +31,7 @@ defmodule EWallet.TransactionConsumptionConsumerGate do
           {:ok, %TransactionConsumption{}}
           | {:error, %TransactionConsumption{}}
           | {:error, atom()}
+          | {:error, atom(), String.t()}
   def consume(
         %{
           "account_id" => account_id,
@@ -147,7 +148,8 @@ defmodule EWallet.TransactionConsumptionConsumerGate do
 
   def consume(_attrs), do: {:error, :invalid_parameter}
 
-  @spec consume(%User{} | %Wallet{}, map()) :: {:ok, %TransactionConsumption{}} | {:error, atom()}
+  @spec consume(%User{} | %Wallet{}, map()) ::
+          {:ok, %TransactionConsumption{}} | {:error, atom()} | {:error, atom(), String.t()}
   def consume(
         %User{} = user,
         %{

diff --git a/mix.exs b/mix.exs
@@ -16,6 +16,7 @@ defmodule EWallet.Umbrella.Mixfile do
       aliases: aliases(),
       docs: docs(),
       dialyzer: [
+        flags: [:underspecs, :unknown, :unmatched_returns],
         plt_add_apps: [:iex, :mix],
         ignore_warnings: ".dialyzer_ignore.exs"
       ]