Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arreglar referencia al mismo EventTarget #172

Merged
merged 6 commits into from
Jul 7, 2024

Conversation

kishtarn555
Copy link
Contributor

@kishtarn555 kishtarn555 commented May 20, 2024

Weird attempt at inheritance resulted in World always having the same this.listeners, resulting in the triggering of events from worlds that were already removed (replaced by a new one)

Fixes: #171
Fixes #148

@kishtarn555
Copy link
Contributor Author

Los test fallan en npm install, pero no creo que sea culpa de este PR

@kishtarn555 kishtarn555 marked this pull request as draft June 9, 2024 05:53
@kishtarn555 kishtarn555 marked this pull request as ready for review June 26, 2024 22:44
@kishtarn555
Copy link
Contributor Author

Linted!

@heduenas heduenas merged commit 96885dd into omegaup:main Jul 7, 2024
2 checks passed
@kishtarn555 kishtarn555 deleted the FixDuplicatedStack branch July 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants