Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating README #71
Updating README #71
Changes from 17 commits
4b0c1e8
115dcbf
0d291cc
494314a
70a1c92
2bc1a06
f6610a2
0cc977f
b3610bc
85eeab3
bf24a6b
fcbc1c8
6c5500b
30c22fe
9db1280
2e6e7cf
42ca428
b36691e
29a8103
08bd5d8
f8bcffd
9c346f5
12cac5b
04eda4e
c6573af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be
Adds a 'Plate Name' column
(from the example below)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
plate
column assumes the data is plate names, not plate ids. Since plate names are provided,omero metadata
adds a new plate column for plate IDs. The confusion comes from the way it adds the column, which is replaced then appends whatever was replaced to the end of the table. Thus technically only added the plate ID column since the original was the plate name. Can attempt to reword the table to what type of column is added (ie names or ids)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit torn between 1- it's important for ourselves to capture knowledge about the current behavior (and eventually to fix it) and 2- users probably do not care :)
If rewording ends up being too tricky, I could imagine using the current wording and adding a footnote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbesson @will-moore Coming back to this, I would add a footnote but there are already multiple notes under the table.
After much brainstorming, I gave it a good attempt in adding more information to the table (in 04eda4e) while capturing knowledge of the current behavior, staying minimalistic, and hopefully improving clarity for the reader/user. Feedback welcome on this change (as I've been staring at it for too long) and happy to revert if you think this is worse or more confusing.