Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from creating columns with python keyword names #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kkoz
Copy link
Contributor

@kkoz kkoz commented Mar 3, 2021

Queries for columns with names matching a python keyword fail. This change prevents the creation of such columns.

@chris-allan
Copy link
Member

Since we know we have problems with columns with spaces probably a good idea to add that too. Can we add a --force or similar to skip this check @kkoz?

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#164. See the console output for more details.
Possible conflicts:

  • Upstream changes
    • src/omero_metadata/cli.py
    • src/omero_metadata/populate.py

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#165. See the console output for more details.
Possible conflicts:

  • Upstream changes
    • src/omero_metadata/cli.py
    • src/omero_metadata/populate.py

--conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants