Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate --context delemap: fix default wait argument #31

Open
sbesson opened this issue Jul 22, 2019 · 0 comments
Open

populate --context delemap: fix default wait argument #31

sbesson opened this issue Jul 22, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@sbesson
Copy link
Member

sbesson commented Jul 22, 2019

See https://forum.image.sc/t/omero-metadata-fails-on-deletemap-when-well-to-images-was-set-yes/27761 and #11 (comment)

The default wait value of the CLI command is set -1 but the logic for handling indefinite waiting is not implemented in the plugin:

wait = args.wait
if wait:
ms = 5000
loops = int((wait * 1000) / ms) + 1

This means the default populate --context deletemap command will fail immediately unless --wait is overriden.

Looking at the implementation in the base GraphControl, two options can be considered for the immediate fix:

  • change the default wait value to None and use some sensible default values for loops and ms
  • implement the wait=-1 use case i.e. wait for the deletion command to finish by default and allow it to be aborted via the CLI
@sbesson sbesson added the bug Something isn't working label Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant