Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare logback as optional dependency #11

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Declare logback as optional dependency #11

merged 1 commit into from
Jan 30, 2023

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jan 17, 2023

@sbesson sbesson requested a review from dgault January 17, 2023 19:52
@jburel
Copy link
Member

jburel commented Jan 18, 2023

it looks like this change leads to an error in omero-blitz build
see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build-build/1421/console

@sbesson
Copy link
Member Author

sbesson commented Jan 18, 2023

Interesting, thanks for reporting. Looks like omero-blitz has an explicit dependency on logback-classic. I can either open an omero-blitz PR declaring the dependency or we can exclude this PR for now. Either way, if logback is truly declared optional in Bio-Formats 6.12.0, we will need this dependency handled at the OMERO level /cc @dgault

@sbesson sbesson mentioned this pull request Jan 18, 2023
Merged
@jburel
Copy link
Member

jburel commented Jan 18, 2023

I have prepared a PR for omero-blitz

@sbesson
Copy link
Member Author

sbesson commented Jan 18, 2023

See ome/omero-blitz#133

@jburel jburel mentioned this pull request Jan 18, 2023
Merged
@jburel
Copy link
Member

jburel commented Jan 20, 2023

see also ome/omero-insight#337

@dgault dgault merged commit cf248bb into ome:master Jan 30, 2023
@sbesson sbesson deleted the logback_optional branch March 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgault dgault dgault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbesson @jburel @dgault