-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDPI: support JPEG-XR and files larger than 4 GB #3505
Conversation
Fixes reading JPEG data that is larger than the MAX_SIZE threshold, but still does not have markers that can be used by JPEGTurboService.
CZI stores BGR JPEG-XR tiles, which the codec/service now internally reverses to RGB.
jxrlib appears not to be thread safe when reading images via Decode objects. This caused intermittent repository test failures. Until a version of jxrlib with improved thread safety is available, this commit should restore tests to a passing state.
Reverted 311e1c8 in 199705a since it didn't actually fix the issue. |
…conditions" This reverts commit 311e1c8.
Revert to using Decode.decodeFirstFrame(...) instead of constructing a new Decode object to get the raw pixels and add metadata parsing to get the pixel type directly.
One more try at fixing the ongoing test failures in 2381e5a. |
Builds and repo tests have been green for a number of days now with the latest commit. Manually tested using the new and updated files from the config PR. Each opened and displayed without issue and the pixel and metadata looked sensible. The additional tags all look like positive additions and I cannot see them causing any issues with existing filesets. I also sanity checked some of the CZI files which had been failing in the builds previously. These too opened and displayed without any issues. Merging for release with 6.4.0 |
Backported from private PRs.
Based on new (private) documentation, this updates NDPI support to allow JPEG-XR compressed tiles, full support for files larger than 4 GB, and some additional metadata tags.
JPEG-XR support required changing the component of the JPEG-XR codec and service from
formats-gpl
toformats-bsd
. Thejxrlib
version also needed to be updated to include glencoesoftware/jxrlib#20, since overview images in files that use JPEG-XR compression store channels in BGR order.Definitely requires a minor release; I would expect memo files to be affected. Requires some configuration changes to NDPI files larger than 4 GB, but otherwise should not fail existing tests.
I suspect, but have not yet thoroughly tested, that this will fix at least a few of the outstanding NDPI issues. To be tested: