fix: dont use Response.json

olros · Apr 26, 2024 · 4725006 · 4725006
1 parent f4cfbf7
commit 4725006
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/web/app/routes/api-internal.$teamSlug.$projectSlug.event.tsx b/web/app/routes/api-internal.$teamSlug.$projectSlug.event.tsx
@@ -11,7 +11,7 @@ import type { CustomEventInput } from '~/types';
 const parseCustomEventInput = async (request: Request): Promise<CustomEventInput> => {
   const data = (await request.json()) as CustomEventInput;
   if (!data.name) {
-    throw Response.json({ errors: { name: `Name isn't defined` } }, { status: 400 });
+    throw new Response(JSON.stringify({ errors: { name: `Name isn't defined` } }), { status: 400 });
   }
 
   return data;
@@ -59,9 +59,9 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
 
     await trackCustomEvent(request, project);
 
-    return Response.json({ ok: true }, { status: 200 });
+    return new Response(JSON.stringify({ ok: true }), { status: 200 });
   } catch (e) {
     console.error('[API-Internal - Event]', e);
-    return Response.json({ ok: false }, { status: 400 });
+    return new Response(JSON.stringify({ ok: false }), { status: 400 });
   }
 };
diff --git a/....$teamSlug.$projectSlug.pageview-next.tsx → ...ernal.$teamSlug.$projectSlug.pageview.tsx b/....$teamSlug.$projectSlug.pageview-next.tsx → ...ernal.$teamSlug.$projectSlug.pageview.tsx
@@ -88,7 +88,7 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
     await trackPageviewNext(request, project);
   } catch (e) {
     console.error('[API-Internal - PageviewNext]', e);
-    return Response.json({ ok: false }, { status: 400 });
+    return new Response(JSON.stringify({ ok: false }), { status: 400 });
   }
-  return Response.json({ ok: true }, { status: 200 });
+  return new Response(JSON.stringify({ ok: true }), { status: 200 });
 };
diff --git a/web/app/routes/api.$teamSlug.$projectSlug.event.tsx b/web/app/routes/api.$teamSlug.$projectSlug.event.tsx
@@ -16,9 +16,9 @@ export const action = async ({ request, params, context }: ActionFunctionArgs) =
     } else {
       await forwardRequestToInternalApi(request, `${params.teamSlug}/${params.projectSlug}/event/`);
     }
-    return Response.json({ ok: true }, { status: 200 });
+    return new Response(JSON.stringify({ ok: true }), { status: 200 });
   } catch (e) {
     console.error('[API - Event]', e);
-    return Response.json({ ok: false }, { status: 400 });
+    return new Response(JSON.stringify({ ok: false }), { status: 400 });
   }
 };
diff --git a/web/app/routes/api.$teamSlug.$projectSlug.pageview.tsx b/web/app/routes/api.$teamSlug.$projectSlug.pageview.tsx
@@ -9,7 +9,7 @@ import invariant from 'tiny-invariant';
 
 import type { PageviewInput } from '~/types';
 
-import type { PageviewRequestData } from './api-internal.$teamSlug.$projectSlug.pageview-next';
+import type { PageviewRequestData } from './api-internal.$teamSlug.$projectSlug.pageview';
 
 export const config = { runtime: 'edge' };
 
@@ -86,7 +86,7 @@ export const action = async ({ request, params, context }: ActionFunctionArgs) =
     const pageViewNextRequest = await getPageViewNextRequest(request);
 
     const promises = Promise.all([
-      ...(pageViewNextRequest ? [forwardRequestToInternalApi(pageViewNextRequest, `${params.teamSlug}/${params.projectSlug}/pageview-next/`)] : []),
+      ...(pageViewNextRequest ? [forwardRequestToInternalApi(pageViewNextRequest, `${params.teamSlug}/${params.projectSlug}/pageview/`)] : []),
     ]);
 
     if ('waitUntil' in ctx) {
@@ -96,7 +96,7 @@ export const action = async ({ request, params, context }: ActionFunctionArgs) =
     }
   } catch (e) {
     console.error('[API - Pageview]', e);
-    return Response.json({ ok: false }, { status: 400 });
+    return new Response(JSON.stringify({ ok: false }), { status: 400 });
   }
-  return Response.json({ ok: true }, { status: 200 });
+  return new Response(JSON.stringify({ ok: true }), { status: 200 });
 };