Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved portuguese translation #648

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Improved portuguese translation #648

merged 3 commits into from
Jan 30, 2024

Conversation

fnasciment0
Copy link
Contributor

Improved portuguese translation file.

Improved portuguese translation file.
Copy link

@xilopaint xilopaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "inserir" is misspelled.

@fnasciment0
Copy link
Contributor Author

Sorry, misspelled solved.

@xilopaint
Copy link

Also, the English version uses the imperative form. Maybe you should write "Insira informações de acesso" instead of "Inserir informações de acesso", "Não use" instead of "Não usar", "Use o método de autenticação" instead of "Usar método de autenticação", "Compartilhe a conexão HTTP" instead of "Partilhar ligação HTTP", "Force o uso do protocolo" instead of "Forçar o uso do protocolo", "Use o URL no primeiro campo" instead of "Usar o URL no primeiro campo".

I'm not from Portugal but it would be the correct approach in Brazilian Portuguese.

@fnasciment0
Copy link
Contributor Author

In Portuguese it is also common to use the infinitive form, both approaches are correct.
Anyway, I'll change it following your recommendations.

@xilopaint
Copy link

I understand that the infinitive form does exist in Portuguese. I'm just pointing out that the English translation uses the imperative form, and it's usually better to follow that pattern.

@ollo69
Copy link
Owner

ollo69 commented Jan 30, 2024

Thanks👍

@ollo69 ollo69 merged commit 2ae6662 into ollo69:master Jan 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants