Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bookmarks): Permit references to tags from previous invocations #7
feat(bookmarks): Permit references to tags from previous invocations #7
Changes from all commits
2720eb2
9ff2f7f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
equals
andhashCode
methods are not consistent. Theequals
method considers bothvalue
andomitted
fields, while thehashCode
method only considers thevalue
field. This inconsistency can lead to unexpected behavior when instances ofBookmarkImpl
are used in collections that rely on these methods.Recommendation: Ensure that both
equals
andhashCode
methods consider the same fields. Either includeomitted
in thehashCode
method or exclude it from theequals
method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constructor
TagImpl(TagImpl parent, TagName name)
initializes theattributes
andnamespaces
fields to empty collections or null. This can lead to potentialNullPointerException
issues if these fields are accessed without null checks elsewhere in the code. Consider initializing these fields to empty collections to avoid such issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constructor
TagImpl(TagImpl parent, TagName name, Attributes attrs, Map<String, String> namespaces)
does not perform a null check on thenamespaces
parameter before callingnamespaces.isEmpty()
. This can lead to aNullPointerException
ifnamespaces
is null. Consider adding a null check for thenamespaces
parameter before using it.