Support strings containing "from now" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebedev
requested changes
Oct 27, 2019
There was a problem hiding this comment.
Suggested patch changes expected behavior fro deadlines from
strict (within|in) <point in time> for (within|in)? <point in time> (from now)?. This means that even a simple point in time will be treated as a deadline. I am not sure about the approach and still think that keep the rule as narrow as possible could save us from the unexpected indeterministic behavior of the parser.
I suggest implementing a rule like(simplified regexp):
((within|in)\s<point in time>)|(<point in time>\sfrom\now)
so it will be a narrower OR.
|
You're right, I hadn't considered that. I'll update it as you suggest. |
|
Hey @j-sv, just a friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for one of the examples listed here.