Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kefan wasm #157

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Kefan wasm #157

wants to merge 17 commits into from

Conversation

FineKe
Copy link
Contributor

@FineKe FineKe commented Sep 29, 2022

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

Codecov Report

Merging #157 (56d7a35) into master (ac565bc) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files          40       40           
  Lines        1104     1104           
=======================================
  Hits          904      904           
  Misses        167      167           
  Partials       33       33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

return resp, fmt.Errorf("failed. encoded stdTx error: %s", err)
}

wrapedTx := &extypes.WrapCMTx{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里建议如果nonce==0则还是按照原先逻辑进行发送,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants