Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add custom scopes to authorisation request #277

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kelvin-chappell
Copy link

@kelvin-chappell kelvin-chappell commented Oct 28, 2022

This change enables the Okta-hosted login app to request additional custom access scopes when authorising.

Custom scopes can now be added as an optional property called CUSTOM_SCOPES in the testenv property file.
Each scope is space separated.
Eg.

CUSTOM_SCOPES=read write

These scopes are then added to the default list and included in the token request.

@Mark-McCracken
Copy link

@jaredperreault-okta can you give this a review and merge if you're happy please?

@jaredperreault-okta
Copy link
Contributor

@kelvin-chappell @Mark-McCracken Do you mind explaining your use case?

@kelvin-chappell
Copy link
Author

@kelvin-chappell @Mark-McCracken Do you mind explaining your use case?

At the moment, if you need to generate an access token with more than the default access scopes configured here you have to search through the code and add them to that array.
By making this a configurable environment variable we improve the dev experience and make it very easy to see, and modify, what scopes have been requested with the token.

@Mark-McCracken
Copy link

@jaredperreault-okta I've been using this for the last few days, which has been helpful for getting certain kinds of access tokens. Do you need anything to get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants