Skip to content

Commit

Permalink
Ognidets version bump (#322)
Browse files Browse the repository at this point in the history
* Version increment to 3.11.0

* Changed error code visibility for tests

* Fix tests referencing underlyingErrors on macOS

Co-authored-by: Mike Nachbaur <[email protected]>
  • Loading branch information
oleggnidets-okta and mikenachbaur-okta authored Dec 2, 2021
1 parent 7a738fc commit 98bfec0
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Example/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.0</string>
<string>$(MARKETING_VERSION)</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand Down
2 changes: 1 addition & 1 deletion OktaOidc.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'OktaOidc'
s.version = '3.10.8'
s.version = '3.11.0'
s.summary = 'SDK to easily integrate AppAuth with Okta'
s.description = <<-DESC
Integrate your native app with Okta using the AppAuth library.
Expand Down
2 changes: 1 addition & 1 deletion Sources/AppAuth/OktaUserAgent.m
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ +(void)setUserAgentValue:(NSString*)value {
}

+(NSString*)userAgentVersion {
return @"3.10.8";
return @"3.11.0";
}

+(NSString*)userAgentHeaderKey {
Expand Down
2 changes: 1 addition & 1 deletion Sources/OktaOidc/Common/OktaOidcError.swift
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public enum OktaOidcError: CustomNSError {
/// Most of errors returns the general error code.
/// Error like `api`, `unexpectedAuthCodeResponse` return specific error code.
/// `api` returns the general error code if `underlyingError` is absent.
private static let generalErrorCode = -1012009
static let generalErrorCode = -1012009

public var errorCode: Int {
switch self {
Expand Down
6 changes: 3 additions & 3 deletions Tests/OktaOidcTests/OktaOidcErrorTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ final class OktaOidcErrorTests: XCTestCase {
XCTAssertEqual(error.userInfo[NSLocalizedDescriptionKey] as! String, error.localizedDescription)
XCTAssertNil(error.userInfo[NSUnderlyingErrorKey] as? NSError)

if #available(iOS 14.5, *) {
if #available(iOS 14.5, macOS 11.3, *) {
XCTAssertTrue(error.underlyingErrors.isEmpty)
}
}
Expand All @@ -47,7 +47,7 @@ final class OktaOidcErrorTests: XCTestCase {
XCTAssertEqual(error.userInfo[NSUnderlyingErrorKey] as! NSError, underlyingError)
XCTAssertEqual(error.userInfo[NSLocalizedDescriptionKey] as! String, error.localizedDescription)

if #available(iOS 14.5, *) {
if #available(iOS 14.5, macOS 11.3, *) {
XCTAssertEqual(error.underlyingErrors.first! as NSError, underlyingError)
}
}
Expand All @@ -60,7 +60,7 @@ final class OktaOidcErrorTests: XCTestCase {
XCTAssertNil(error.userInfo[NSUnderlyingErrorKey] as? NSError)
XCTAssertEqual(error.userInfo[NSLocalizedDescriptionKey] as! String, error.localizedDescription)

if #available(iOS 14.5, *) {
if #available(iOS 14.5, macOS 11.3, *) {
XCTAssertTrue(error.underlyingErrors.isEmpty)
}
}
Expand Down
10 changes: 6 additions & 4 deletions okta-oidc.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1764,7 +1764,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.10.8;
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = "com.okta.okta-oidc";
PRODUCT_NAME = OktaOidc;
SKIP_INSTALL = YES;
Expand Down Expand Up @@ -1794,7 +1794,7 @@
"@executable_path/Frameworks",
"@loader_path/Frameworks",
);
MARKETING_VERSION = 3.10.8;
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = "com.okta.okta-oidc";
PRODUCT_NAME = OktaOidc;
SKIP_INSTALL = YES;
Expand All @@ -1816,6 +1816,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = com.okta.Example;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
Expand All @@ -1834,6 +1835,7 @@
"$(inherited)",
"@executable_path/Frameworks",
);
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = com.okta.Example;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
Expand Down Expand Up @@ -1940,7 +1942,7 @@
"@loader_path/Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.14;
MARKETING_VERSION = 3.10.8;
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = "com.okta.okta-oidc";
PRODUCT_NAME = OktaOidc;
SDKROOT = macosx;
Expand All @@ -1967,7 +1969,7 @@
"@loader_path/Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.14;
MARKETING_VERSION = 3.10.8;
MARKETING_VERSION = 3.11.0;
PRODUCT_BUNDLE_IDENTIFIER = "com.okta.okta-oidc";
PRODUCT_NAME = OktaOidc;
SDKROOT = macosx;
Expand Down

0 comments on commit 98bfec0

Please sign in to comment.