fix client assertion not send through POST body #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tien Nguyen <[email protected]>
monde
reviewed
Dec 16, 2024
Signed-off-by: Tien Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
okta-aws-cli is using the private_key_jwt client authentication method for requesting access_tokens from the POST /oauth2/v1/token endpoint in a non-standard way that is accepted by the POST /oauth2/v1/token endpoint.
It includes the client_assertion in the query string of the request instead of in the POST body. This is problematic because query strings should never contain sensitive data as they are prone to being logged.
The purpose of this PR is to move client_assertion from query string to POST body to avoid being logged