WIP debug open browser command

okta · Jan 24, 2024 · 47d8005 · 47d8005
1 parent e74230c
commit 47d8005
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/internal/webssoauth/webssoauth.go b/internal/webssoauth/webssoauth.go
@@ -751,15 +751,16 @@ func (w *WebSSOAuthentication) promptAuthentication(da *okta.DeviceAuthorization
 			bArgs = append(bArgs, da.VerificationURIComplete)
 			cmd := osexec.Command(bArgs[0], bArgs[1:]...)
 			out, err := cmd.Output()
-			if _, ok := err.(*osexec.ExitError); ok {
+			// TODO don't strategically swallow all errors?
+			// if _, ok := err.(*osexec.ExitError); ok {
+			if err != nil {
 				w.consolePrint("Failed to open activation URL with given browser: %v\n", err)
 				w.consolePrint("  %s\n", strings.Join(bArgs, " "))
 			}
 			if len(out) > 0 {
 				w.consolePrint("browser output:\n%s\n", string(out))
 			}
 		}
-
 	} else if w.config.OpenBrowser() {
 		brwsr.Stdout = os.Stderr
 		if err := brwsr.OpenURL(da.VerificationURIComplete); err != nil {