Fix error when flawed okta.yaml can cause a panic if error not checked.

okta · Nov 2, 2023 · 3561c6f · 3561c6f
1 parent 2e98960
commit 3561c6f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/internal/webssoauth/webssoauth.go b/internal/webssoauth/webssoauth.go
@@ -513,9 +513,8 @@ func (w *WebSSOAuthentication) promptForRole(idp string, roleARNs []string) (rol
 // If the fedApp has already been selected via an ask one survey we don't need
 // to pretty print out the IdP name again.
 func (w *WebSSOAuthentication) promptForIDP(idpARNs []string) (idpARN string, err error) {
-	oktaConfig, _ := w.config.OktaConfig()
 	var configIDPs map[string]string
-	if err == nil {
+	if oktaConfig, cErr := w.config.OktaConfig(); cErr == nil {
 		configIDPs = oktaConfig.AWSCLI.IDPS
 	}