Merge pull request #172 from okta/issue_168_open_browser_flag

Open browser and open browser command behavior was fouled in v2 release
okta · Feb 9, 2024 · 34ac6f4 · 34ac6f4
2 parents 490e0c0 + 61ebe7d
commit 34ac6f4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Changelog
 
+## Major.Minor.Revision (Month Day, Year)
+
+TBD
+
+### BUG FIXES
+
+* Open browser and open browser command behavior was fouled in v2 release [#NNN](https://github.com/okta/okta-aws-cli/pull/NNN), thanks [@monde](https://github.com/monde)!
+
 ## 2.0.1 (January 31, 2024)
 
 ### ENHANCEMENTS

diff --git a/internal/config/config.go b/internal/config/config.go
@@ -453,9 +453,11 @@ func readConfig() (Attributes, error) {
 		attrs.OpenBrowser = viper.GetBool(downCase(OpenBrowserEnvVar))
 	}
 	if attrs.OpenBrowserCommand == "" {
+		attrs.OpenBrowserCommand = viper.GetString(downCase(OpenBrowserCommandEnvVar))
+	}
+	if attrs.OpenBrowserCommand != "" {
 		// open browser command implies open browser
 		attrs.OpenBrowser = true
-		attrs.OpenBrowserCommand = viper.GetString(downCase(OpenBrowserCommandEnvVar))
 	}
 	if !attrs.Debug {
 		attrs.Debug = viper.GetBool(downCase(DebugEnvVar))