Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncation issue in DataTable #2426

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jordankoschei-okta
Copy link
Contributor

Fixes this overflow edge case flagged by Sheri:

image

@jordankoschei-okta jordankoschei-okta requested a review from a team as a code owner November 21, 2024 18:42
!shouldDisplayRowActions && hasColumnResizing
? "ods-hide-spacer-column"
: "",
className: !shouldDisplayRowActions && hasColumnResizing ? "" : "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordankoschei-okta We are never setting any className here. Might as well just remove this prop or set it as empty string.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does removing this reintroduce weird last column issues we've seen in the past?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants