Add Test Selector for Banner Component #2304
Open
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
42
to
52
| close: { | ||
| selector: { | ||
| method: "ByLabelText", | ||
| text: "${labelText}", | ||
| templateVariableNames: ["labelText"], | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
We should probably use ByRole where we can. In this case, we're looking for a button with a label "Close", not the just the text "Close".
Suggested change
| close: { | |
| selector: { | |
| method: "ByLabelText", | |
| text: "${labelText}", | |
| templateVariableNames: ["labelText"], | |
| }, | |
| }, | |
| }, | |
| closeButton: { | |
| selector: { | |
| method: "ByRole", | |
| options: { | |
| name: "${labelText}", | |
| }, | |
| role: "button", | |
| templateVariableNames: ["labelText"], | |
| }, | |
| }, | |
| }, |
AnirudhMani-okta
force-pushed
the
am-OKTA-754442-banner-component-test-selector
branch
from
59b664d to
73a3b09
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754442-banner-component-test-selector
branch
from
73a3b09 to
b9f6cea
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754442-banner-component-test-selector
branch
from
b9f6cea to
c75b8db
Compare
|
Updated Test Selectors code is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-754442
Summary
Testing & Screenshots