Allow jobs to choose when to save log output #1082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrafto
suggested changes
Feb 19, 2017
There was a problem hiding this comment.
I don't like using CRITICAL for info logging - it should be reserved for unrecoverable errors. It's also not obvious or documented, so job writers aren't likely to use it.
How about instead, if the logging handler receives a message and it has been more than X seconds since the last flush, then flush the log output anyway? It would allow slow-printing jobs to show output more quickly without requiring special attention from the job writer.
|
Sure - that should work. What do you think a reasonable interval is? 15? |
|
Sure, it might require some manual tuning to find the right number |
|
@Sumukh Are you still planning on working on this PR? |
|
@colinschoen Nope. Feel free to take this over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a message is logged with a level of critical (or higher) - the log is immediately saved (instead of having to wait for 10 more messages)
This allows jobs some level of control over what gets displayed when. It's especially useful for jobs that might not print lots of information (like the autograding job - previously the user had to wait for about a minute before they got any output)