Sample Test Details: Fix Padding and enclose status and result with i18n #9387

rithviknishad · 2024-12-12T04:43:53Z

Issue reported by @nihal467 ; caused recently by #9138 cc: @modamaan

Proposed Changes

Fixes padding for sample test history card in sample details page
Enclose sample details status and result options i18n.

Before	After

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Improved rendering of sample details and patient information with enhanced spacing.
- Updated Badge components for better localization and uppercase formatting.
Bug Fixes
- Retained error handling for navigation to a "not-found" page on unsuccessful queries.
Style
- Adjusted layout for improved visual presentation of sample and patient details.

coderabbitai · 2024-12-12T04:44:00Z

Walkthrough

The changes in the SampleDetails.tsx file focus on improving the rendering of sample and patient information. Adjustments include enhanced layout with added margin and padding, updates to Badge components for better localization, and retention of existing error handling and loading state management. The overall structure of the showPatientCard function remains unchanged, ensuring consistent display of patient data while supporting conditional rendering based on nationality.

Changes

File	Change Summary
`src/components/Patient/SampleDetails.tsx`	Adjusted layout with additional margin and padding; updated `Badge` components for uppercase and localization; retained error handling and loading state management.

Possibly related PRs

Fix Conditional Rendering of TextAreaFormField for Sample Test Type #8960: Modifies SampleDetails.tsx to introduce internationalization support.
Updated Test Details page form UI #9138: Updates SampleDetails.tsx with UI enhancements and restructuring.
UI enhancement to Sample Test History #9193: Enhances layout and spacing of rendered flow data in SampleDetails.tsx.
Fixed Breadcrumb to Display Detailed Name Instead of ID #9200: Adds a new property for breadcrumb navigation in SampleDetails.tsx.

Suggested labels

tested, needs review

Suggested reviewers

Jacobjeevan

Poem

In the garden of code, where rabbits play,
Sample details bloom in a bright new way.
With badges in uppercase, they proudly stand,
Localization whispers, "We understand!"
Padding and margins, a layout so fine,
A hop and a skip, all functions align! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-12T04:44:13Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`a591a62`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/675a6a0b2554250008abb14a
😎 Deploy Preview	https://deploy-preview-9387--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress · 2024-12-12T04:54:16Z

CARE Run #4017

Run Properties: Passed #4017 • a591a62864: Sample Test Details: Fix Padding and enclose status and result with i18n

Project	`CARE`
Branch Review	`rithviknishad/fix/sample-test-padding-and-i18n`
Run status	`Passed #4017`
Run duration	`05m 25s`
Commit	`a591a62864: Sample Test Details: Fix Padding and enclose status and result with i18n`
Committer	`Rithvik Nishad`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`154`
View all changes introduced in this branch ↗︎

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

src/components/Patient/SampleDetails.tsx (2)
326-327: LGTM: Status badge with proper i18n support

Good implementation of i18n for the status badge. Consider extracting the translation key prefix "SAMPLE_TEST_HISTORY__" as a constant to maintain consistency and ease future updates.
+const SAMPLE_TEST_HISTORY_I18N_PREFIX = "SAMPLE_TEST_HISTORY__";
+
 <Badge variant="outline" className="font-semibold uppercase">
-  {t(`SAMPLE_TEST_HISTORY__${sampleDetails?.status}`)}
+  {t(`${SAMPLE_TEST_HISTORY_I18N_PREFIX}${sampleDetails?.status}`)}
 </Badge>
334-335: LGTM: Result badge with proper i18n support

Good implementation of i18n for the result badge. Consider extracting the translation key prefix "SAMPLE_TEST_RESULT__" as a constant for consistency.
+const SAMPLE_TEST_RESULT_I18N_PREFIX = "SAMPLE_TEST_RESULT__";
+
 <Badge variant="secondary" className="font-semibold uppercase">
-  {t(`SAMPLE_TEST_RESULT__${sampleDetails?.result}`)}
+  {t(`${SAMPLE_TEST_RESULT_I18N_PREFIX}${sampleDetails?.result}`)}
 </Badge>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05d89f4 and a591a62.

📒 Files selected for processing (1)

src/components/Patient/SampleDetails.tsx (3 hunks)

🔇 Additional comments (2)

src/components/Patient/SampleDetails.tsx (2)

268-268: LGTM: Improved layout with proper spacing

The grid layout with responsive columns and consistent spacing improves the visual presentation of the sample test history card.

543-543: LGTM: Consistent spacing for test history items

The added margin and padding provide proper visual separation between test history items.

github-actions · 2024-12-12T11:35:00Z

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sample Test Details: Fix Padding and enclose status and result with i18n

a591a62

rithviknishad requested a review from a team as a code owner December 12, 2024 04:43

rithviknishad added the needs review label Dec 12, 2024

coderabbitai bot reviewed Dec 12, 2024

View reviewed changes

Jacobjeevan approved these changes Dec 12, 2024

View reviewed changes

rithviknishad requested a review from khavinshankar December 12, 2024 11:33

khavinshankar approved these changes Dec 12, 2024

View reviewed changes

khavinshankar merged commit 8a3a59f into develop Dec 12, 2024
70 checks passed

khavinshankar deleted the rithviknishad/fix/sample-test-padding-and-i18n branch December 12, 2024 11:34

coderabbitai bot mentioned this pull request Dec 22, 2024

Update the Card Design in Notice Board #9343

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sample Test Details: Fix Padding and enclose status and result with i18n #9387

Sample Test Details: Fix Padding and enclose status and result with i18n #9387

rithviknishad commented Dec 12, 2024 •

edited

Loading

coderabbitai bot commented Dec 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 12, 2024 •

edited

Loading

cypress bot commented Dec 12, 2024

coderabbitai bot left a comment

github-actions bot commented Dec 12, 2024

Sample Test Details: Fix Padding and enclose status and result with i18n #9387

Sample Test Details: Fix Padding and enclose status and result with i18n #9387

Conversation

rithviknishad commented Dec 12, 2024 • edited Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Dec 12, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 12, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

cypress bot commented Dec 12, 2024

CARE Run #4017

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 12, 2024

rithviknishad commented Dec 12, 2024 •

edited

Loading

coderabbitai bot commented Dec 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 12, 2024 •

edited

Loading