Fix responsiveness of FacilityCard and ManagePatients components #9276
Conversation
WalkthroughThe changes in this pull request involve updates to the layout and styling of components in two files: Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/components/Patient/ManagePatients.tsx (2)
799-799: Remove extra whitespace.There's an extra whitespace character that should be removed.
-<div > +<div>🧰 Tools
🪛 eslint
[error] 799-799: Delete
·(prettier/prettier)
🪛 GitHub Check: lint
[failure] 799-799:
Delete·
Line range hint
896-921: Consider adding error handling for export functionality.While the export implementation is good, consider adding error handling for the CSV export operation to gracefully handle potential failures.
action: async () => { const query = { ...params, csv: true, facility: qParams.facility, }; delete qParams.is_active; - const { data } = await request(routes.patientList, { - query, - }); - return data ?? null; + try { + const { data } = await request(routes.patientList, { + query, + }); + return data ?? null; + } catch (error) { + Notification.Error({ + msg: "Failed to export patient data. Please try again.", + }); + return null; + } },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/components/Facility/FacilityCard.tsx(1 hunks)src/components/Patient/ManagePatients.tsx(4 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/components/Facility/FacilityCard.tsx
🧰 Additional context used
🪛 eslint
src/components/Patient/ManagePatients.tsx
[error] 799-799: Delete ·
(prettier/prettier)
🪛 GitHub Check: lint
src/components/Patient/ManagePatients.tsx
[failure] 799-799:
Delete ·
🔇 Additional comments (2)
src/components/Patient/ManagePatients.tsx (2)
799-844: LGTM! Responsive layout implementation looks good.
The flex layout structure with responsive classes (w-full md:w-1/2 lg:w-fit) provides a good mobile-first approach, ensuring the buttons stack properly on smaller screens and align horizontally on larger ones.
🧰 Tools
🪛 eslint
[error] 799-799: Delete ·
(prettier/prettier)
🪛 GitHub Check: lint
[failure] 799-799:
Delete ·
Line range hint 880-895: LGTM! Well-implemented button with analytics and accessibility.
The doctor connect button implementation includes:
- Responsive width classes for different screen sizes
- Proper analytics tracking with
triggerGoal - Accessibility support with proper ID
|
Duplicate of #9161 |
|
the add patient button is thrown off... 
|
|
Closing as duplicate as mentioned in #9276 (comment) |
|
@ayushpatil2122 avoid working on issues without getting them assigned. We can avoid duplicate PRs that way. |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Style