Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

responsive: shiftingDetails page and Breadcrumbs added phone and desktop #8933

Closed
wants to merge 5 commits into from
Closed

responsive: shiftingDetails page and Breadcrumbs added phone and desktop #8933

wants to merge 5 commits into from

Conversation

modamaan
Copy link
Contributor

Proposed Changes

change the button alignment when phone size

Before
Screenshot 2024-10-20 000900

After
Screenshot 2024-10-20 011739

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@modamaan modamaan requested a review from a team as a code owner October 26, 2024 17:27
@netlify Netlify
Copy link

netlify bot commented Oct 26, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5f6f9b8
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671f99d4a8851000083ce1b6
😎 Deploy Preview https://deploy-preview-8933--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@modamaan
Copy link
Contributor Author

@bodhish @rithviknishad

loom-video.2.mp4

@shivankacker
Copy link
Member

@modamaan unable to understand the breadcrumbs relation here, could you elaborate more in the PR description?

@shivankacker shivankacker added the question Further information is requested label Oct 26, 2024
@modamaan
Copy link
Contributor Author

@shivankacker #8833 (comment)

@modamaan
Copy link
Contributor Author

modamaan commented Oct 27, 2024 •
edited
Loading

Proposed Changes

add responsive shadcn breadcrumbs

Current version
Screenshot 2024-10-27 055208

Last item broken

Screenshot 2024-10-27 055401

No dropdown here

Updated version

Screenshot 2024-10-27 055745
Last item broken issue solved

Screenshot 2024-10-27 055906
Shadcn Dropdown added

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@bodhish
Copy link
Member

bodhish commented Oct 27, 2024

Duplicate of #8833

@bodhish bodhish marked this as a duplicate of #8833 Oct 27, 2024
@bodhish bodhish added blocked and removed question Further information is requested labels Oct 27, 2024
bodhish
bodhish requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I will actually add icons for non paths in the dropdown.

Example

  • 🏢 Critical Care
  • 🗳 Assets

unicodes are just for illustration.

I expect these changes to be made on the previous PR

src/components/Common/Breadcrumbs.tsx Outdated Show resolved Hide resolved
@modamaan
Copy link
Contributor Author

@bodhish Screenshot 2024-10-28 193508

@modamaan modamaan requested a review from bodhish October 28, 2024 14:14
@modamaan
Copy link
Contributor Author

modamaan commented Oct 30, 2024 •
edited
Loading

@bodhish i made a mistake, created branch from local branch instead of develop branch. this caused it to include all commits from my other branch, i would like to create new branch and resolve this issue

@modamaan modamaan closed this Oct 30, 2024
@modamaan modamaan deleted the issues/8831/edit-shiftingDetailspage branch October 30, 2024 14:35
@modamaan modamaan mentioned this pull request Oct 30, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

phone size responsive issue shifting details page
3 participants
@modamaan @shivankacker @bodhish