Fixed shifting details page responsiveness and add shadcn Breadcrump #8860
Conversation
❌ Deploy Preview for care-ohc failed.
|
|
shadcn added https://ui.shadcn.com/docs/components/breadcrumb loom-video.1.mp4 |
There was a problem hiding this comment.
- Fix all lint issues, also check if your auto format is working
- Remove unused variables and functions, this should have been caught before committing in pre commit hook 🤔. Check your setup
- Lets have one behaviour both desktop and mobile, keep it as close as how Shadcn works.
- UI should match, from the video I can quickly spot that you are missing a
>at the end
|
there is no |
|
on the video you shared I can see that we are missing a |
|
👋 Hi, @modamaan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
@bodhish how to resolve conflict issue |
modamaan
force-pushed
the
issues/8831/edit-shiftingDetailspage
branch
from
ffa285f to
ec5a01d
Compare
|
@rithviknishad can you check the updates |
There was a problem hiding this comment.
You missed to implmenet
- Fix all lint issues, also check if your auto format is working. (How did the lint miss catching the quotes issue 🤔)
- Lets have one behaviour both desktop and mobile, keep it as close as how Shadcn works.
Its having the old behavior in desktop and new one in mobile screens.
Other Changes
-
...is having a different color, it look alike right 🤔
- Login seems to be broken for showing the last item.
Before
after
- Somehow home button lost an underline;
- why is logic with
MENU_TAGSremoved?
before requesting the review make sure all these changes are tested.
|
updated phone and desktop |
Proposed Changes
change the button alignment when phone size
Before
After
@ohcnetwork/care-fe-code-reviewers
Merge Checklist