Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styling for the side nav #8789

Merged
merged 15 commits into from
Oct 16, 2024
Merged

Update styling for the side nav #8789

merged 15 commits into from
Oct 16, 2024

Conversation

vinutv
Copy link
Member

@vinutv vinutv commented Oct 14, 2024 •
edited by rithviknishad
Loading

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vinutv vinutv requested a review from a team as a code owner October 14, 2024 22:42
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit b99485f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670f98095ea9ca0008ab7380
😎 Deploy Preview https://deploy-preview-8789--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vinutv vinutv self-assigned this Oct 14, 2024
@vinutv vinutv marked this pull request as draft October 14, 2024 22:43
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024 •
edited
Loading

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: b99485f
Status: ✅  Deploy successful!
Preview URL: https://9c78ec8e.care-fe.pages.dev
Branch Preview URL: https://side-nav-styling.care-fe.pages.dev

View logs

@cypress Cypress
Copy link

cypress bot commented Oct 14, 2024 •
edited
Loading

CARE    Run #3683

Run Properties:  status check passed Passed #3683  •  git commit b99485f074: Update styling for the side nav
Project CARE
Run status status check passed Passed #3683
Run duration 03m 17s
Commit git commit b99485f074: Update styling for the side nav
Committer Vinu
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@vinutv vinutv marked this pull request as ready for review October 15, 2024 15:11
bodhish
bodhish approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihal467 do fix the specs here

Also lets gets this merged asap

@bodhish bodhish mentioned this pull request Oct 15, 2024
Merged
6 tasks
vinutv
vinutv commented Oct 15, 2024
View reviewed changes
src/Components/Common/Sidebar/Sidebar.tsx Outdated
</button>
</TooltipTrigger>
<TooltipContent>
<p>{shrinked ? "Expand Sidebar" : "Collapse Sidebar"}</p>
Copy link
Member Author

@vinutv vinutv Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihal467 Could you help update this with i18n translation?

@rithviknishad rithviknishad mentioned this pull request Oct 16, 2024
Closed
@nihal467
Copy link
Member

nihal467 commented Oct 16, 2024 •
edited by vinutv
Loading

Bug

image

  • when user names are long, the text is overflowing and collapse icon is clipping-n in the sidebar

@vinutv
Copy link
Member Author

vinutv commented Oct 16, 2024

Bug

image

  • when user names are long, the text is overflowing and collapse icon is clipping-n in the sidebar

@nihal467 Implemented truncation for the username. 82966c3

@github-actions GitHub Actions
Copy link

👋 Hi, @vinutv,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 16, 2024 •
edited by rithviknishad
Loading

@vinutv @rithviknishad

image

  • Currently, when the user clicks to open the profile dropdown and then attempts to access the "Asset" tab, the dropdown closes on the initial click, and the "Asset" tab only opens after a subsequent click. The expected behavior is that upon clicking the "Asset" tab, the profile dropdown should automatically close, and the "Asset" tab should open in a single action.
  • Clear the merge conflict @rithviknishad

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 16, 2024
@rithviknishad rithviknishad mentioned this pull request Oct 16, 2024
Closed
6 tasks
@vinutv
Copy link
Member Author

vinutv commented Oct 16, 2024

  • Currently, when the user clicks to open the profile dropdown and then attempts to access the "Asset" tab, the dropdown closes on the initial click, and the "Asset" tab only opens after a subsequent click. The expected behavior is that upon clicking the "Asset" tab, the profile dropdown should automatically close, and the "Asset" tab should open in a single action.

@nihal467
Yes, The ideal interaction behaviour is for the new link to open even when the dropdown is still active.
Could we address this as a separate issue?

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit bbb7503 into develop Oct 16, 2024
29 checks passed
@khavinshankar khavinshankar deleted the side-nav-styling branch October 16, 2024 11:22
@github-actions GitHub Actions
Copy link

@vinutv @nihal467 @vinutv Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@nihal467 nihal467 mentioned this pull request Oct 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak left review comments

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish bodhish approved these changes

Assignees

@vinutv vinutv

@nihal467 nihal467

Labels
tested
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tooltip for Expand,Profile and Logout
6 participants
@vinutv @nihal467 @bodhish @rithviknishad @khavinshankar @sainak