Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded Cypress to 13.14.2 and Removed @types/cypress #8788

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 14, 2024

Proposed Changes

  • cypress 13.15.0 , is having type check issue because its not recognising the file structure properly
  • types/cypress is not needed anymore since cypress v10+ provided its on built-in typecheck
  • removed typecheck in tsconfig, since its conflict with inbuilt type check

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nihal467 nihal467 requested a review from a team as a code owner October 14, 2024 20:40
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 59a22d9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670d83320f8e83000897da95
😎 Deploy Preview https://deploy-preview-8788--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59a22d9
Status: ✅  Deploy successful!
Preview URL: https://c0d9e901.care-fe.pages.dev
Branch Preview URL: https://cypress-config.care-fe.pages.dev

View logs

@nihal467 nihal467 changed the title Downgraded Cypress to 14.0 and Removed @types/cypress Downgraded Cypress to 13.14.2 and Removed @types/cypress Oct 14, 2024
Copy link

cypress bot commented Oct 14, 2024

CARE    Run #3646

Run Properties:  status check passed Passed #3646  •  git commit 59a22d9db8: Downgraded Cypress to 14.0 and Removed @types/cypress
Project CARE
Run status status check passed Passed #3646
Run duration 03m 09s
Commit git commit 59a22d9db8: Downgraded Cypress to 14.0 and Removed @types/cypress
Committer Mohammed Nihal
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124

@nihal467 nihal467 self-assigned this Oct 14, 2024
@khavinshankar khavinshankar merged commit a45285a into develop Oct 15, 2024
32 checks passed
@khavinshankar khavinshankar deleted the cypress-config branch October 15, 2024 00:18
Copy link

@nihal467 @nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants