Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 3rd Party Software Licenses Page #8748

Merged
merged 26 commits into from
Oct 21, 2024
Merged

Added 3rd Party Software Licenses Page #8748

merged 26 commits into from
Oct 21, 2024

Conversation

tellmeY18
Copy link
Member

Proposed Changes

  • Fixes Add third-party Licenses #8484
  • Created SBOM Viewer and License Page
  • Added Routes to /licenses and linked it to Login Page
  • setup workflow to generate cyclonedx sbom.json

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@tellmeY18 tellmeY18 requested a review from a team as a code owner October 9, 2024 12:54
@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 788a239
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671239f4a9e6f4000802c581
😎 Deploy Preview https://deploy-preview-8748--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the generated file git ignored and generate it during the build step instead of using a CI?

cc: @bodhish

rithviknishad
rithviknishad requested changes Oct 10, 2024
View reviewed changes
src/Components/SBOMViewer.tsx Outdated Show resolved Hide resolved
src/Components/SBOMViewer.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Oct 14, 2024 •
edited
Loading

Bug

image

  • the dedicated license page is not mobile-responsive

UI Enhancement

image

  • The external reference in the current UI gives the impression that it's empty. I would suggest adding an icon to collapse and expand, so users understand that data exists and they can click on the icon to view it

UI Enhancement Question

image

image

@rithviknishad shall we change 3rd to Third, along with adding " | " for separation, would that look better in the UI?

@rithviknishad @tellmeY18

@nihal467 nihal467 added test failed question Further information is requested and removed needs testing labels Oct 14, 2024
@rithviknishad rithviknishad added needs testing and removed question Further information is requested test failed labels Oct 15, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 16, 2024 •
edited
Loading

@rithviknishad @tellmeY18
image

the mobile view is still not fully responsive

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @tellmeY18,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@tellmeY18 tellmeY18 closed this Oct 16, 2024
@tellmeY18 tellmeY18 reopened this Oct 16, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 16, 2024
@nihal467
Copy link
Member

LGTM

@bodhish bodhish merged commit b9d7801 into ohcnetwork:develop Oct 21, 2024
22 checks passed
@github-actions GitHub Actions
Copy link

@tellmeY18 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add third-party Licenses
5 participants
@tellmeY18 @nihal467 @rithviknishad @bodhish @khavinshankar