Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip for expand logout profile #8733

Conversation

anandaashish74711
Copy link

@anandaashish74711 anandaashish74711 commented Oct 7, 2024

Sidebar Tooltip Enhancement

This pull request addresses an issue where tooltips were missing for the "Expand", "Profile", and "Logout" icons when the sidebar is minimized. This resulted in users accidentally clicking the "Logout" icon instead of the "Expand" icon.

@rithviknishad

Changes:

  • Fixes Issue: Replace #8585 with the actual issue number.
  • Added tooltips for the following icons in minimized sidebar mode:
    • Expand
    • Profile
    • Logout
  • Ensured tooltips are properly visible and accessible when the sidebar is minimized.

Reason for the Change

In the minimized sidebar, users were accidentally clicking the "Logout" button when they intended to click the "Expand" button. Adding tooltips for these icons improves the user experience by providing descriptive labels, helping users differentiate between the buttons.

Merge Checklist

  • Added tests or specs to verify that the tooltips work correctly in both minimized and expanded sidebar modes.
  • Updated product documentation if needed to reflect the change.
  • Ensured that all UI text (tooltips) is properly localized using I18n files.
  • Prepared and attached a screenshot or demo video showcasing the tooltips for inclusion in the changelog.
  • Requested peer reviews for code validation.
  • Completed QA verification to ensure the feature works as expected in different scenarios.

How to Use

After the merge, the new tooltips will appear in the sidebar when it is minimized. When hovering over the icons for "Expand", "Profile", or "Logout", users will now see descriptive tooltips to guide them in making the correct selection.

Screenshot

ohc3.mp4

Testing Instructions:

  1. Open the sidebar in its minimized mode.
  2. Hover over the "Expand", "Profile", and "Logout" icons to see the tooltips.
  3. Verify that the tooltips display the correct information.
  4. Test on different screen sizes to ensure the tooltips are accessible and behave consistently.

@anandaashish74711 anandaashish74711 requested a review from a team as a code owner October 7, 2024 13:09
Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 68e08f9
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6703de230d08000008992013
😎 Deploy Preview https://deploy-preview-8733--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have another PR that actually changes the layout of the sidebar. Please branch out from that branch keeping it the base.
#8680

Copy link

github-actions bot commented Oct 8, 2024

👋 Hi, @anandaashish74711,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 8, 2024
@anandaashish74711
Copy link
Author

We have another PR that actually changes the layout of the sidebar. Please branch out from that branch keeping it the base. #8680

#8680 branch (Re-build sidebar UI) has already been merged into develop. it is giving me error ,(fatal: 'origin/Re-build-sidebar-UI-#8680' is not a commit and a branch 'Add-tooltip-to-expand-profile-logout' cannot be created from it) is there another branch I should base my changes on? Please let me know

@rithviknishad
Copy link
Member

It'd be easier to create a fresh PR from using latest develop branch

@nihal467
Copy link
Member

@anandaashish74711 any update on this PR,

@anandaashish74711
Copy link
Author

I added a fresh pr but getting Cypress error

@rithviknishad
Copy link
Member

Closing as duplicate of #8747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants