Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add user media ready and camera permission denied notifications #8688

Merged
merged 5 commits into from
Oct 9, 2024
Merged

fix: Add user media ready and camera permission denied notifications #8688

merged 5 commits into from
Oct 9, 2024

Conversation

shauryag2002
Copy link
Contributor

Proposed Changes

Video of changes:

camera_fix.mp4

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shauryag2002 shauryag2002 requested a review from a team as a code owner October 1, 2024 22:38
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 4a155cf
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6705759658bebe0008d6d078
😎 Deploy Preview https://deploy-preview-8688--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2024

@shauryag2002
image

  • Remove the notification, when the camera feed is on. Notification is only required when the permission is denied

@shauryag2002
Copy link
Contributor Author

@nihal467, Removed the notification, when the camera feed is on.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

👋 Hi, @shauryag2002,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Oct 8, 2024

LGTM

@nihal467 nihal467 added tested and removed needs testing merge conflict pull requests with merge conflict labels Oct 8, 2024
khavinshankar
khavinshankar approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shauryag2002 LGTM nice work, just a heads up on future PRs, no need to add translations for each language (English is enough), rest will be handled using crowdin.

@khavinshankar khavinshankar merged commit 4b2c827 into ohcnetwork:develop Oct 9, 2024
22 of 23 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

@shauryag2002 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Camera Permission Handling and User Media Notifications indication
5 participants
@shauryag2002 @nihal467 @khavinshankar @bodhish @rithviknishad