Investigations Print Preview Page #8679

Jacobjeevan · 2024-10-01T05:18:05Z

Proposed Changes

Fixes Increase the width of investigation view details page padding #8583
Created a different print preview page for investigations, similar to prescriptions print preview (Medications tab)
Modified Investigations view page to have no scrollbar (+ print button redirects to print preview page instead)

Investigations tab

Investigations View Page

Investigations Print Preview Page

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

- Created a different print preview page for investigations, similar to medications - Changed the existing Investigations print page to just view page (i.e. print button redirects to print preview page instead)

netlify · 2024-10-01T05:18:23Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`2b6ff47`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/670fb0950a30d10008543790
😎 Deploy Preview	https://deploy-preview-8679--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

LGTM, just i18n

src/Components/Facility/Investigations/ViewInvestigations.tsx

src/Components/Facility/Investigations/InvestigationTable.tsx

nihal467 · 2024-10-01T12:45:36Z

@Jacobjeevan

in mobile view, the inputted data in the field is not visible

reduce the width of the value field in normal view, as its not that much required

when we save the edited value, the users have been redirected to the consultation dashboard, it shouldn't be the expected behavior, keep the user in the same page itself to view the updated value

- Disable navigate on save for investigations form edit - Also replace the initial values after submit (correct behavior when clicking cancel following a form submission) - Using translations for terms - Adjusted width of table in view page

Jacobjeevan · 2024-10-03T05:22:51Z

in mobile view, the inputted data in the field is not visible

reduce the width of the value field in normal view, as its not that much required

when we save the edited value, the users have been redirected to the consultation dashboard, it shouldn't be the expected behavior, keep the user in the same page itself to view the updated value

👍 @nihal467

nihal467 · 2024-10-03T10:30:09Z

@aparnacoronasafe can you look into the new investigation print preview, without requesting @Jacobjeevan added patient admission, IP/OP no, allergies, and bed no to the print preview of the investigation, is it ok to keep it or should we remove them and only keep the patient name and facility name in the investigation print preview

bodhish · 2024-10-03T19:51:28Z

~~Lets add it; the prints should eventually have everything we store.~~
Lets remove it @Jacobjeevan, Investigation doesn't need it

Jacobjeevan · 2024-10-04T06:22:17Z

@nihal467 I was working on #8275, should we do the same thing here and move print button inside?

nihal467 · 2024-10-04T19:29:11Z

@Jacobjeevan yes we can do it and once the PR is ready, let me know

Jacobjeevan · 2024-10-07T04:27:49Z

@nihal467 Ready 👍

github-actions · 2024-10-09T19:13:34Z

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2024-10-13T00:24:26Z

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

nihal467 · 2024-10-14T09:53:30Z

@Jacobjeevan the persist in Chrome browser, responsive view of iPhone 14 pro, can you look it

- Adjusted padding for result (spacing for inputText in mobile and tab view) - Removed the print classnames (no longer used as this page isn't for print)

Jacobjeevan · 2024-10-14T12:35:22Z

@Jacobjeevan the persist in Chrome browser, responsive view of iPhone 14 pro, can you look it

@nihal467 Got it 👍 Take a look now.

nihal467 · 2024-10-16T07:44:33Z

LGTM

github-actions · 2024-10-16T10:24:25Z

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

github-actions · 2024-10-16T12:45:39Z

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Investigations View

3890c0e

- Created a different print preview page for investigations, similar to medications - Changed the existing Investigations print page to just view page (i.e. print button redirects to print preview page instead)

Jacobjeevan requested a review from a team as a code owner October 1, 2024 05:18

nihal467 added the needs testing label Oct 1, 2024

rithviknishad reviewed Oct 1, 2024

View reviewed changes

src/Components/Facility/Investigations/ViewInvestigations.tsx Outdated Show resolved Hide resolved

src/Components/Facility/Investigations/ViewInvestigations.tsx Outdated Show resolved Hide resolved

src/Components/Facility/Investigations/InvestigationTable.tsx Outdated Show resolved Hide resolved

nihal467 added test failed and removed needs testing labels Oct 1, 2024

Jacobjeevan and others added 2 commits October 3, 2024 10:26

Investigations

43cee7b

- Disable navigate on save for investigations form edit - Also replace the initial values after submit (correct behavior when clicking cancel following a form submission) - Using translations for terms - Adjusted width of table in view page

Merge branch 'develop' into issues/8583-investigationsView-noScroll

56ba7d9

github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 3, 2024

added comma

01c53cb

Jacobjeevan requested a review from rithviknishad October 3, 2024 05:26

rithviknishad added needs testing and removed test failed Deploy-Failed Deplyment is not showing preview labels Oct 3, 2024

rithviknishad approved these changes Oct 3, 2024

View reviewed changes

nihal467 added the question Further information is requested label Oct 3, 2024

bodhish removed the question Further information is requested label Oct 3, 2024

Jacobjeevan added 2 commits October 4, 2024 06:07

Removed patient details from Investigations print page

1a0d453

Merge branch 'develop' into issues/8583-investigationsView-noScroll

1ea01e5

nihal467 added work-in-progress and removed needs testing labels Oct 4, 2024

Moved print button inside body for InvestigationTable

0224ea0

Merge branch 'develop' into issues/8583-investigationsView-noScroll

4ee99a7

Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 9, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Oct 9, 2024

Merge branch 'develop' into issues/8583-investigationsView-noScroll

eac245e

Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 11, 2024

nihal467 added needs testing and removed changes required labels Oct 11, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Oct 13, 2024

Merge branch 'develop' into issues/8583-investigationsView-noScroll

6a6bee3

Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 14, 2024

nihal467 added test failed and removed needs testing labels Oct 14, 2024

Adjusted padding

cb7952f

- Adjusted padding for result (spacing for inputText in mobile and tab view) - Removed the print classnames (no longer used as this page isn't for print)

Jacobjeevan added needs testing and removed test failed labels Oct 15, 2024

nihal467 added tested and removed needs testing labels Oct 16, 2024

github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024

Merge branch 'develop' into issues/8583-investigationsView-noScroll

2b6ff47

github-actions bot removed the merge conflict pull requests with merge conflict label Oct 16, 2024

khavinshankar approved these changes Oct 16, 2024

View reviewed changes

khavinshankar merged commit a8fd4c1 into ohcnetwork:develop Oct 16, 2024
22 of 23 checks passed

Jacobjeevan deleted the issues/8583-investigationsView-noScroll branch November 6, 2024 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Investigations Print Preview Page #8679

Investigations Print Preview Page #8679

Jacobjeevan commented Oct 1, 2024 •

edited

Loading

netlify bot commented Oct 1, 2024 •

edited

Loading

rithviknishad left a comment

nihal467 commented Oct 1, 2024

Jacobjeevan commented Oct 3, 2024

nihal467 commented Oct 3, 2024 •

edited

Loading

bodhish commented Oct 3, 2024 •

edited

Loading

Jacobjeevan commented Oct 4, 2024

nihal467 commented Oct 4, 2024 •

edited

Loading

Jacobjeevan commented Oct 7, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 13, 2024

nihal467 commented Oct 14, 2024 •

edited

Loading

Jacobjeevan commented Oct 14, 2024

nihal467 commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

Investigations Print Preview Page #8679

Investigations Print Preview Page #8679

Conversation

Jacobjeevan commented Oct 1, 2024 • edited Loading

Proposed Changes

Investigations tab

Investigations View Page

Investigations Print Preview Page

Merge Checklist

netlify bot commented Oct 1, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment

Choose a reason for hiding this comment

nihal467 commented Oct 1, 2024

Jacobjeevan commented Oct 3, 2024

nihal467 commented Oct 3, 2024 • edited Loading

bodhish commented Oct 3, 2024 • edited Loading

Jacobjeevan commented Oct 4, 2024

nihal467 commented Oct 4, 2024 • edited Loading

Jacobjeevan commented Oct 7, 2024 • edited Loading

github-actions bot commented Oct 9, 2024

github-actions bot commented Oct 13, 2024

nihal467 commented Oct 14, 2024 • edited Loading

Jacobjeevan commented Oct 14, 2024

nihal467 commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

Jacobjeevan commented Oct 1, 2024 •

edited

Loading

netlify bot commented Oct 1, 2024 •

edited

Loading

nihal467 commented Oct 3, 2024 •

edited

Loading

bodhish commented Oct 3, 2024 •

edited

Loading

nihal467 commented Oct 4, 2024 •

edited

Loading

Jacobjeevan commented Oct 7, 2024 •

edited

Loading

nihal467 commented Oct 14, 2024 •

edited

Loading