Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved issue #8583 - Increased width to remove unnecessary scrollbar #8630

Closed
wants to merge 2 commits into from
+7 −1
Closed

fix: resolved issue #8583 - Increased width to remove unnecessary scrollbar #8630

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db4ade8
fix: fixed issue #8583 Increased the width of PrintPreview page to re…
syedfardeenjeelani Sep 25, 2024
9e178b1
Update PrintPreview.tsx
syedfardeenjeelani Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/CAREUI/misc/PrintPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,13 @@ export default function PrintPreview(props: Props) {

return (
<Page title={props.title}>
<div className="mx-auto my-8 w-[50rem]">
{/* INCREASED WIDTH TO REMOVE SCROLLBAR */}

{/* PREVIOUS WIDTH = 50REM

UPDATED WIDTH = 64REM */}

<div className="mx-auto my-8 lg:w-[64rem]">
Comment on lines +23 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reusable component meant to be used to show how to print would look like. Instead of modifying this component, let's have two pages:

  1. The one that shows the Investigation Details with all the interactive components such as update details, select menu etc...

  2. And a print button that takes you to the print preview page, which will not have any interactive components in the print preview. Select Menu doesn't and other interactive elements should not be part of the "print preview".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

<div className="top-0 z-20 flex gap-2 bg-secondary-100 px-2 py-4 xl:absolute xl:right-6 xl:top-8 xl:justify-end">
<ButtonV2 disabled={props.disabled} onClick={print}>
<CareIcon icon="l-print" className="text-lg" />
Expand Down
Loading