Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made a reusable component for table in routine and nursing care procedures #8608

Closed
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
227 changes: 138 additions & 89 deletions src/Components/Facility/ConsultationDetails/ConsultationNursingTab.tsx
Original file line number Diff line number Diff line change
@@ -1,41 +1,24 @@
import { useEffect, useState } from "react";
import { ConsultationTabProps } from "./index";
import { NursingPlot } from "../Consultations/NursingPlot";
import { useTranslation } from "react-i18next";
import request from "../../../Utils/request/request";
import routes from "../../../Redux/api";
import { RoutineAnalysisRes, RoutineFields } from "../models";
import {
RoutineAnalysisRes,
RoutineFields,
NursingPlotFields,
} from "../models";
import Loading from "../../Common/Loading";
import { classNames, formatDate, formatTime } from "../../../Utils/utils";
import Pagination from "../../Common/Pagination";
import { PAGINATION_LIMIT } from "../../../Common/constants";
import {
PAGINATION_LIMIT,
NURSING_CARE_PROCEDURES,
} from "../../../Common/constants";
import LogUpdateAnalayseTable from "../Consultations/LogUpdateAnalayseTable";
import { formatDateTime } from "../../../Utils/utils";

import PageTitle from "@/Components/Common/PageTitle";

export default function ConsultationNursingTab(props: ConsultationTabProps) {
const { t } = useTranslation();
return (
<div>
<PageTitle
title={t("nursing_information")}
hideBack
breadcrumbs={false}
/>
<div>
<h4>{t("routine")}</h4>
<RoutineSection {...props} />
</div>
<div>
<h4>{t("nursing_care")}</h4>
<NursingPlot
facilityId={props.facilityId}
patientId={props.patientId}
consultationId={props.consultationId}
/>
</div>
</div>
);
}
import { ConsultationTabProps } from ".";
import { ProcedureType } from "@/Components/Common/prescription-builder/ProcedureBuilder";

const REVERSE_CHOICES = {
appetite: {
Expand Down Expand Up @@ -109,6 +92,105 @@ const ROUTINE_ROWS = [
{ subField: true, field: "appetite" } as const,
];

const NursingPlot = ({ consultationId }: ConsultationTabProps) => {
const { t } = useTranslation();
const [results, setResults] = useState<any>({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid any as much as possible, please add a valid type here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sahil-Sinha-11 the changes look good, just this, can you please replace this any with respective type

const [currentPage, setCurrentPage] = useState(1);
const [totalCount, setTotalCount] = useState(0);

useEffect(() => {
const fetchDailyRounds = async (
currentPage: number,
consultationId: string,
) => {
const { res, data } = await request(routes.dailyRoundsAnalyse, {
body: { page: currentPage, fields: NursingPlotFields },
pathParams: { consultationId },
});
if (res && res.ok && data) {
setResults(data.results);
setTotalCount(data.count);
}
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add error handling for failed API requests

Currently, there is no error handling if the API request fails. Consider adding error handling to improve user feedback.

Apply this diff:

           });
+          if (!res || !res.ok) {
+            // Handle error
+            console.error('Failed to fetch daily rounds data');
+            // You may also set an error state to display a user-friendly message
+            return;
+          }

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools
🪛 Biome

[error] 110-110: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

fetchDailyRounds(currentPage, consultationId);
}, [consultationId, currentPage]);

const handlePagination = (page: number) => setCurrentPage(page);

const data = Object.entries(results).map((key: any) => ({
date: formatDateTime(key[0]),
nursing: key[1]["nursing"],
}));

const dataToDisplay = data
.map((x) =>
x.nursing.map((f: any) => {
f["date"] = x.date;
return f;
}),
)
.reduce((accumulator, value) => accumulator.concat(value), []);

const filterEmpty = (field: (typeof NURSING_CARE_PROCEDURES)[number]) => {
const filtered = dataToDisplay.filter(
(i: ProcedureType) => i.procedure === field,
);
return filtered.length > 0;
};

const areFieldsEmpty = () => {
let emptyFieldCount = 0;
for (const field of NURSING_CARE_PROCEDURES) {
if (!filterEmpty(field)) emptyFieldCount++;
}
return emptyFieldCount === NURSING_CARE_PROCEDURES.length;
};

const rows = NURSING_CARE_PROCEDURES.filter((f) => filterEmpty(f)).map(
(procedure) => ({
field: procedure,
title: t(`NURSING_CARE_PROCEDURE__${procedure}`),
}),
);

const mappedData = dataToDisplay.reduce(
(acc: Record<string, any>, item: any) => {
if (!acc[item.date]) acc[item.date] = {};
acc[item.date][item.procedure] = item.description;
return acc;
},
{},
);

return (
<div>
<div>
{areFieldsEmpty() ? (
<div className="mt-1 w-full rounded-lg border bg-white p-4 shadow">
<div className="flex items-center justify-center text-2xl font-bold text-secondary-500">
{t("no_data_found")}
</div>
</div>
) : (
<LogUpdateAnalayseTable data={mappedData} rows={rows} />
)}
</div>

{totalCount > PAGINATION_LIMIT && !areFieldsEmpty() && (
<div className="mt-4 flex w-full justify-center">
<Pagination
cPage={currentPage}
defaultPerPage={PAGINATION_LIMIT}
data={{ totalCount }}
onChange={handlePagination}
/>
</div>
)}
</div>
);
};

const RoutineSection = ({ consultationId }: ConsultationTabProps) => {
const { t } = useTranslation();
const [page, setPage] = useState(1);
Expand Down Expand Up @@ -153,65 +235,11 @@ const RoutineSection = ({ consultationId }: ConsultationTabProps) => {

return (
<div className="pb-8 pt-4">
<div className="m-2 w-full overflow-hidden overflow-x-auto rounded-lg border border-black shadow md:w-fit">
<table className="border-collapse overflow-hidden rounded-lg border bg-secondary-100">
<thead className="bg-white shadow">
<tr>
<th className="w-48 border-b-2 border-r-2 border-black" />
{Object.keys(results).map((date) => (
<th
key={date}
className="border border-b-2 border-secondary-500 border-b-black p-1 text-sm font-semibold"
>
<p>{formatDate(date)}</p>
<p>{formatTime(date)}</p>
</th>
))}
</tr>
</thead>
<tbody className="bg-secondary-200">
{ROUTINE_ROWS.map((row) => (
<tr
key={row.field ?? row.title}
className={classNames(
row.title && "border-t-2 border-t-secondary-600",
)}
>
<td
className={classNames(
"border border-r-2 border-secondary-500 border-r-black bg-white p-2",
row.subField ? "pl-4 font-medium" : "font-bold",
)}
>
{row.title ?? t(`LOG_UPDATE_FIELD_LABEL__${row.field!}`)}
</td>
{row.field &&
Object.values(results).map((obj, idx) => (
<td
key={`${row.field}-${idx}`}
className={classNames(
"border border-secondary-500 bg-secondary-100 p-2 text-center font-medium",
)}
>
{(() => {
const value = obj[row.field];
if (value == null) {
return "-";
}
if (typeof value === "boolean") {
return t(value ? "yes" : "no");
}
const choices = REVERSE_CHOICES[row.field];
const choice = `${row.field.toUpperCase()}__${choices[value as keyof typeof choices]}`;
return t(choice);
})()}
</td>
))}
</tr>
))}
</tbody>
</table>
</div>
<LogUpdateAnalayseTable
data={results}
rows={ROUTINE_ROWS}
choices={REVERSE_CHOICES}
/>

{totalCount != null && totalCount > PAGINATION_LIMIT && (
<div className="mt-4 flex w-full justify-center">
Expand All @@ -226,3 +254,24 @@ const RoutineSection = ({ consultationId }: ConsultationTabProps) => {
</div>
);
};

export default function ConsultationNursingTab(props: ConsultationTabProps) {
const { t } = useTranslation();
return (
<div>
<PageTitle
title={t("nursing_information")}
hideBack
breadcrumbs={false}
/>
<div>
<h4>{t("routine")}</h4>
<RoutineSection {...props} />
</div>
<div>
<h4>{t("nursing_care")}</h4>
<NursingPlot {...props} />
</div>
</div>
);
}
127 changes: 127 additions & 0 deletions src/Components/Facility/Consultations/LogUpdateAnalayseTable.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
import React from "react";
import { formatDate, formatTime } from "../../../Utils/utils";
import { classNames } from "../../../Utils/utils";
import { useTranslation } from "react-i18next";

interface SharedSectionTableProps {
data: Record<string, any>;
rows: Array<{ title?: string; field?: string; subField?: boolean }>;
choices?: Record<string, Record<number | string, string>>;
}

const LogUpdateAnalayseTable: React.FC<SharedSectionTableProps> = ({
data,
rows,
choices = {},
}) => {
const { t } = useTranslation();

// Helper function to get the display value
const getDisplayValue = (
value: string | boolean | null | undefined,
field?: string,
): string => {
if (value == null) {
return " ";
}

if (typeof value === "boolean") {
return t(value ? "yes" : "no");
}
if (field && choices[field]) {
const choice =
choices[field][value as keyof (typeof choices)[typeof field]];
return choice ? t(`${field.toUpperCase()}__${choice}`) : "-";
}
if (value && typeof value == "string") return value;

return "-";
};

const isValidDate = (str: string) => {
let ct = 0;
for (let i = 0; i < str.length; i++) {
if (str[i] == "/") ct++;
}

if (ct == 2) return true;
return false;
};

const dateConversion = (str: string) => {
const time = str.split(";")[0].trim();

const date = str.split(";")[1].trim();

const dd = date.split("/")[0];
const mm = date.split("/")[1];

const yyyy = date.split("/")[2];

return time + ";" + mm + "/" + dd + "/" + yyyy;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use formatDateTime instead of this right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rithviknishad actually formatDateTime uses days.js that expects date in format mm/dd/yyyy but the date format passed in nursingtab was different so I had to convert the format and then pass it to formatDateTime function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the format of time received? I am pretty sure you can transform a format to other super easily.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From ChatGPT

In this case, you can utilize day.js to handle the date format transformation easily. Here's a suggestion for tackling the date formatting using day.js:

  1. You can parse the incoming date string using day.js, and then transform it to the format required by formatDateTime.

Here’s a sample implementation for transforming the date format:

import dayjs from 'dayjs';

const dateConversion = (str: string) => {
  const [time, date] = str.split(';').map(s => s.trim());

  // Assuming the incoming date is in "dd/mm/yyyy" format
  const parsedDate = dayjs(date, 'DD/MM/YYYY');
  
  // Format the date to the required "mm/dd/yyyy" format for formatDateTime
  const formattedDate = parsedDate.format('MM/DD/YYYY');

  return `${time}; ${formattedDate}`;
};

In this implementation:

  • The date is first split and trimmed.
  • The dayjs(date, 'DD/MM/YYYY') parses the input date, assuming the format DD/MM/YYYY.
  • The .format('MM/DD/YYYY') converts it into the required MM/DD/YYYY format for formatDateTime.

You can now pass the result to formatDateTime easily after this conversion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend is giving the data in standard format @Sahil-Sinha-11

image

However you are already formatting it when sending the data to the component after receiving it from the backend, and then deconstructing the formatted back to unformatted, just for format it again?

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rithviknishad I am not able to run the application it shows a file does not exist( pluginMap). I even tried on devlop branch.
Screenshot 2024-10-21 at 10 30 25 PM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rithviknishad , I resolved it .


return (
<div className="m-2 w-full overflow-hidden overflow-x-auto rounded-lg border border-black shadow md:w-fit">
<table className="border-collapse rounded-lg border bg-secondary-100">
<thead className="sticky top-0 bg-white shadow">
<tr>
<th className="sticky left-0 border-b-2 border-r-2 border-black bg-white"></th>
{Object.keys(data).map((date) => (
<>
<th
key={date}
className="w-40 border border-b-2 border-secondary-500 border-b-black p-1 text-sm font-semibold"
>
{/* DD/MM/YYYY -> MM/DD/YYYY */}
<p>
{isValidDate(date)
? formatDate(dateConversion(date))
: formatDate(date)}
</p>
<p>
{isValidDate(date)
? formatTime(dateConversion(date))
: formatTime(date)}
</p>
</th>
</>
))}
</tr>
</thead>
<tbody className="bg-secondary-200">
{rows.map((row) => (
<tr
key={row.field ?? row.title}
className={classNames(
row.title && "border-t-2 border-t-secondary-600",
)}
>
<th
className={classNames(
"sticky left-0 border border-r-2 border-secondary-500 border-r-black bg-white p-2",
row.subField ? "pl-4 font-medium" : "font-bold",
)}
>
{row.title ?? t(`LOG_UPDATE_FIELD_LABEL__${row.field!}`)}
</th>
{Object.values(data).map((obj, idx) => {
const value = obj[row.field!];
return (
<td
key={`${row.field}-${idx}`}
className="w-80 border border-l-2 border-secondary-500 bg-secondary-100 p-2 text-center font-medium"
>
{getDisplayValue(value, row.field)}
</td>
);
})}
</tr>
))}
</tbody>
</table>
</div>
);
};

export default LogUpdateAnalayseTable;
Loading
Loading