Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with sidebar indicator #8536

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

shivankacker
Copy link
Member

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner September 13, 2024 19:31
@shivankacker shivankacker self-assigned this Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit a713821
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66ebb40ba6a96900081b5655
😎 Deploy Preview https://deploy-preview-8536--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 13, 2024

CARE    Run #3397

Run Properties:  status check passed Passed #3397  •  git commit a713821c83: Fixed bug with sidebar indicator
Project CARE
Branch Review sidebar-indicator-bug
Run status status check passed Passed #3397
Run duration 03m 17s
Commit git commit a713821c83: Fixed bug with sidebar indicator
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 126
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit d5fb1a1 into develop Sep 24, 2024
26 checks passed
@khavinshankar khavinshankar deleted the sidebar-indicator-bug branch September 24, 2024 14:46
Copy link

@shivankacker @shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar bug on resize
4 participants