Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cypress action; separate setup and run #8460

Closed
wants to merge 2 commits into from
Closed

Refactor cypress action; separate setup and run #8460

wants to merge 2 commits into from

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Sep 2, 2024 •
edited by bodhish
Loading

Refactor cypress action; separate setup and run

@khavinshankar khavinshankar requested a review from a team as a code owner September 2, 2024 12:09
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 89b5c87
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d5ae7ae9d7480008c7d8bf
😎 Deploy Preview https://deploy-preview-8460--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bodhish
Copy link
Member

bodhish commented Sep 3, 2024

@khavinshankar any idea why the tests are timing out?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

rithviknishad
rithviknishad requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care backend is not running in the second job

@github-actions github-actions bot added the stale label Sep 12, 2024
@github-actions github-actions bot removed the stale label Oct 1, 2024
@bodhish bodhish assigned nihal467 and unassigned khavinshankar Oct 7, 2024
@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@nihal467 please take this up, this should potentially reduce the time for specs.

@nihal467 nihal467 removed their assignment Oct 8, 2024
@nihal467
Copy link
Member

nihal467 commented Oct 14, 2024 •
edited
Loading

@khavinshankar #8738 (comment) , I have tried a lot of approaches to resolve the issue, seem like there are limitation for GitHub action job processing, feel free to try other alternatives otherwise close the PR

@github-actions github-actions bot added the stale label Oct 26, 2024
@nihal467
Copy link
Member

nihal467 commented Nov 6, 2024

Closing in favour of experimenting with different approach: #8989

@nihal467 nihal467 closed this Nov 6, 2024
@khavinshankar khavinshankar deleted the cypress-action-refactor branch December 1, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@bodhish bodhish bodhish approved these changes

Assignees

@nihal467 nihal467

Labels
Carried over changes required merge conflict pull requests with merge conflict stale
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khavinshankar @bodhish @nihal467 @rithviknishad