-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for "Still watching" prompt to prevent users from idling when watching stream #8440
Adds support for "Still watching" prompt to prevent users from idling when watching stream #8440
Conversation
… when watching stream
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adding i18n... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the time configurable via env;
How about through config.json instead? (All whitelablling envs are present there) |
Also @bodhish the configuration should be for the base delay for the linear backoff right? |
I'm not sure where we have kept the end, but let's keep it at a unified place. Also set a sensible default, if the env is not present, the default should be taken |
@rithviknishad the camera authentication frontend PR is buggy so keep this PR on hold since the camera feed is not working in develop |
@nihal467 This can be tested without the feed being live. The still watching component wrapper is agnostic of where it's used. It just wraps over any component and observes for touches within that wrapped component. |
LGTM |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Proposed Changes
(Set a faster timeout in screen recording for demo purpose)
Screen.Recording.2024-08-29.at.19.23.31.mov
@ohcnetwork/code-reviewers
Merge Checklist